Handle corner cases for utils (#124)

Author: liyanhui1228

compatibility_lib/compatibility_lib/dependency_highlighter.py

@@ -14,10 +14,10 @@
 
 import concurrent.futures
 import enum
+import logging
 import re
 
 from compatibility_lib import compatibility_checker
-from compatibility_lib import compatibility_store
 from compatibility_lib import configs
 from compatibility_lib import utils
 
@@ -154,11 +154,23 @@ def check_package(self, package_name):
             try:
                 install = _sanitize_release_tag(info['installed_version'])
             except UnstableReleaseError as err:
+                install = None
                 priority = Priority(PriorityLevel.HIGH_PRIORITY, str(err))
 
+
             if not info['is_latest'] or priority.level != PriorityLevel.UP_TO_DATE:
+                current_time = info['current_time']
+                latest_version_time = info['latest_version_time']
+
+                # Skip the check if release timestamp is None.
+                if current_time is None or latest_version_time is None:
+                    logging.warning(
+                        'Release time for dependency {} is not available.'
+                            .format(name))
+                    continue
+
                 latest =  _sanitize_release_tag(info['latest_version'])
-                elapsed_time = info['current_time']-info['latest_version_time']
+                elapsed_time = current_time - latest_version_time
 
                 if priority.level == PriorityLevel.UP_TO_DATE:
                     priority = self._get_update_priority(

compatibility_lib/compatibility_lib/test_utils.py

@@ -106,7 +106,11 @@ def test_get_dependency_info_endpoint(self):
 class Test__parse_datetime(unittest.TestCase):
 
   def test__parse_datetime(self):
-    date_string = '2018-08-16T15:42:04.351677'
-    expected = '2018-08-16 00:00:00'
-    res = utils._parse_datetime(date_string)
-    self.assertEqual(str(res), expected)
+      date_string = '2018-08-16T15:42:04.351677'
+      expected = '2018-08-16 00:00:00'
+      res = utils._parse_datetime(date_string)
+      self.assertEqual(str(res), expected)
+
+  def test__parse_datetime_empty(self):
+      res = utils._parse_datetime(None)
+      self.assertIsNone(res)

compatibility_lib/compatibility_lib/utils.py

@@ -90,6 +90,13 @@ def _get_from_endpoint(self, package_name):
         result = [item for item in _result]
         depinfo = result[0][0].get('dependency_info')
 
+        # depinfo can be None if there is an exception during pip install.
+        if depinfo is None:
+            logging.warning(
+                "Could not get the dependency info of package {} from server."
+                    .format(package_name))
+            return {}
+
         fields = ('installed_version_time',
                   'current_time', 'latest_version_time')
         for pkgname in depinfo.keys():
@@ -123,6 +130,9 @@ def _parse_datetime(date_string):
     Returns:
         the date as a datetime obj
     """
+    if date_string is None:
+        return None
+
     date_string = date_string.replace('T', ' ')
     short_date = date_string.split(' ')[0]
     return datetime.strptime(short_date, DATETIME_FORMAT)