Add a warning icon to the tabs (#178)

Author: liyanhui1228

badge_server/main.py

@@ -278,6 +278,8 @@ def one_badge_image():
     if badge_name is None:
         badge_name = package_name
 
+    badge_name = _sanitize_badge_name(badge_name)
+
     force_run_check = flask.request.args.get('force_run_check')
     # Remove the last '/' from the url root
     url_prefix = flask.request.url_root[:-1]
@@ -304,6 +306,7 @@ def one_badge_image():
 
     details_link = url_prefix + flask.url_for('one_badge_target',
                                               package=package_name)
+
     response = flask.make_response(
         pybadges.badge(
             left_text=badge_name,
@@ -380,7 +383,7 @@ def run_check():
                 else py3_description
             version_and_res['py3']['details'] = py3_details
 
-        # Write the result to memory store
+        # Write the result to Cloud Datastore
         CACHE.set(
             '{}_self_comp_badge'.format(package_name), version_and_res)
 
@@ -470,7 +473,7 @@ def run_check():
         res['details'] = details
         res['deprecated_deps'] = deprecated_deps
 
-        # Write the result to memory store
+        # Write the result to Cloud Datastore
         CACHE.set(
             '{}_dependency_badge'.format(package_name), res)
 
@@ -571,7 +574,7 @@ def run_check():
                             py_version]['details'][package] = details
             result = version_and_res
 
-        # Write the result to memory store
+        # Write the result to Cloud Datastore
         CACHE.set(
             '{}_google_comp_badge'.format(package_name), result)
 

badge_server/requirements.txt

@@ -1,4 +1,4 @@
-compatibility_lib==0.0.10
+compatibility_lib==0.0.11
 Flask==1.0.2
 google-cloud-bigquery==1.3.0
 google-cloud-datastore==1.7.0

badge_server/templates/google-compatibility.html

@@ -48,10 +48,18 @@ <h4>Google Compatibility Check Results</h4>
 
                             <ul class="nav nav-tabs" id="myTab" role="tablist">
                                 <li class="nav-item">
-                                    <a class="nav-link active" id="py2-tab" data-toggle="tab" href="#py2" role="tab" aria-controls="py2" aria-selected="true">Python 2</a>
+                                    <a class="nav-link active" id="py2-tab" data-toggle="tab" href="#py2" role="tab" aria-controls="py2" aria-selected="true">Python 2
+                                    {% if result.py2.status == "CHECK_WARNING" %}
+                                        <span class="badge badge-warning">Warning</span>
+                                    {% endif %}
+                                    </a>
                                 </li>
                                 <li class="nav-item">
-                                    <a class="nav-link" id="py3-tab" data-toggle="tab" href="#py3" role="tab" aria-controls="py3" aria-selected="false">Python 3</a>
+                                    <a class="nav-link" id="py3-tab" data-toggle="tab" href="#py3" role="tab" aria-controls="py3" aria-selected="false">Python 3
+                                    {% if result.py3.status == "CHECK_WARNING" %}
+                                        <span class="badge badge-warning">Warning</span>
+                                    {% endif %}
+                                    </a>
                                 </li>
                             </ul>
                             <div class="tab-content pl-3 p-1" id="myTabContent">

badge_server/templates/one-badge.html

@@ -168,10 +168,18 @@ <h4>Google Compatibility Check Results</h4>
 
                         <ul class="nav nav-tabs" id="myTab" role="tablist">
                             <li class="nav-item">
-                                <a class="nav-link active" id="py2-tab" data-toggle="tab" href="#py2" role="tab" aria-controls="py2" aria-selected="true">Python 2</a>
+                                <a class="nav-link active" id="py2-tab" data-toggle="tab" href="#py2" role="tab" aria-controls="py2" aria-selected="true">Python 2
+                                {% if google_compat_res.py2.status == "CHECK_WARNING" %}
+                                    <span class="badge badge-warning">Warning</span>
+                                {% endif %}
+                                </a>
                             </li>
                             <li class="nav-item">
-                                <a class="nav-link" id="py3-tab" data-toggle="tab" href="#py3" role="tab" aria-controls="py3" aria-selected="false">Python 3</a>
+                                <a class="nav-link" id="py3-tab" data-toggle="tab" href="#py3" role="tab" aria-controls="py3" aria-selected="false">Python 3
+                                {% if google_compat_res.py3.status == "CHECK_WARNING" %}
+                                    <span class="badge badge-warning">Warning</span>
+                                {% endif %}
+                                </a>
                             </li>
                         </ul>
                         <div class="tab-content pl-3 p-1" id="myTabContent">