Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Commit 570868b

Browse files
authored
Remove the work around for renaming (#156)
1 parent 7b1dd9d commit 570868b

1 file changed

Lines changed: 8 additions & 12 deletions

File tree

dashboard/dashboard_builder.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,14 @@ def get_package_details(self, p: package.Package):
183183
'latest_version': '0.1.0',
184184
}
185185
"""
186-
# TODO: Will remove after a new build to update the bigquery data.
187-
pkg_name = p.install_name
188-
if p.install_name == 'apache-beam[gcp]':
189-
pkg_name = 'google-cloud-dataflow'
186+
# The package being checked will appear in the dep list, but for
187+
# apache-beam[gcp], the package in dep list will just be apache-beam.
188+
self_dep_name = p.install_name
189+
if '[' in p.install_name:
190+
self_dep_name = p.install_name.split('[')[0]
191+
190192
latest_version = self._package_with_dependency_info[
191-
pkg_name][pkg_name]['latest_version']
193+
p.install_name][self_dep_name]['latest_version']
192194
pairwise_conflict = []
193195

194196
# Initialize the values
@@ -201,10 +203,7 @@ def get_package_details(self, p: package.Package):
201203
for pair_pkg in configs.PKG_LIST:
202204
check_result = self.get_result(p, package.Package(pair_pkg))
203205
# Get self compatibility status
204-
# TODO: Will remove after a new build to update the bigquery data.
205-
if pair_pkg == 'apache-beam[gcp]':
206-
pair_pkg = 'google-cloud-dataflow'
207-
if pair_pkg == pkg_name:
206+
if pair_pkg == p.install_name:
208207
result['self_conflict'] = True \
209208
if check_result['status_type'] != 'self-success' else False
210209
# Get pairwise compatibility status
@@ -366,9 +365,6 @@ def main():
366365

367366
package_with_dependency_info = {}
368367
for pkg in configs.PKG_LIST:
369-
# TODO: Will remove after a new build to update the bigquery data.
370-
if pkg == 'apache-beam[gcp]':
371-
pkg = 'google-cloud-dataflow'
372368
dep_info = store.get_dependency_info(pkg)
373369
package_with_dependency_info[pkg] = dep_info
374370

0 commit comments

Comments
 (0)