This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Add eventListener options (capture, passive, once)#14
Open
DougAnderson444 wants to merge 10 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Author
|
Hello, The CLA is complete for this pull request to add the Can someone please review it? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters
Great library! For my use case, I also needed to capture the event, but this option wasn't available... until now. I threw in passive and once for good measure, but really I was after capture.
I added the capture option to my fork, simple change which seems to work well. I present this pull request as a token of my appreciation for making this library in the first place.
Thanks :)