Reference changes size on 32-bit platforms

[alexanderkjall]

The test size_of_reference indicates that it's important that references are exactly 80 bytes, but that is not true on 32-bit platforms.

See this patch: https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/gix-ref/debian/patches/allow-reference-to-be-smaller-on-32-bit.patch

Should this test be updated to pass on 32-bit?

[EliahKagan]

This was fixed about ten months ago in fc13fc3 (#1687), along with a number of other test cases that had the same kind of problem.

(At the time I am writing this comment, the current version of gix-ref is 0.53.1, while the version in the debcargo-conf source tree linked in your message is based on gix-ref 0.48.0.)

[alexanderkjall]

Great, sorry for bringing up old stuff, I'm in the process of reviewing and trying to upstream our patches in the rust team in debian.

[EliahKagan]

No problem! Also, if you find any such test cases that have not been fixed--or where the fix that is in place is not working properly--and you're willing to report them, please do! I'm not confident that I've found them all: when I worked on this about ten months ago, I tested on a few 32-bit platforms and fixed all the test cases that failed, but there may be others.