Revert to hasattr test, as it works with tempfile's dynamic class wrappers

Author: JamesParrott

run_benchmarks.py

@@ -85,11 +85,14 @@ def write_shapefile_with_PyShp(target: str | PathLike):
 for file_path in SHAPEFILES.values():
     file_path.read_bytes()
 
+COLS_WIDTHS = (22, 10)
+
 reader_benchmarks = [
     functools.partial(
         benchmark,
         name=f"Read {test_name}",
         func=functools.partial(open_shapefile_with_PyShp, target=target),
+        col_widths=COLS_WIDTHS,
     )
     for test_name, target in SHAPEFILES.items()
 ]
@@ -101,13 +104,17 @@ def write_shapefile_with_PyShp(target: str | PathLike):
         benchmark,
         name=f"Write {test_name}",
         func=functools.partial(write_shapefile_with_PyShp, target=target),
+        col_widths=COLS_WIDTHS,
     )
     for test_name, target in SHAPEFILES.items()
 ]
 
 
-def run(run_count: int, benchmarks: list[Callable[[], None]]) -> None:
-    col_widths = (22, 10)
+def run(
+    run_count: int,
+    benchmarks: list[Callable[[], None]],
+    col_widths: tuple[int, int] = COLS_WIDTHS,
+) -> None:
     col_head = ("parser", "exec time", "performance (more is better)")
     print(f"Running benchmarks {run_count} times:")
     print("-" * col_widths[0] + "---" + "-" * col_widths[1])
@@ -116,7 +123,6 @@ def run(run_count: int, benchmarks: list[Callable[[], None]]) -> None:
     for benchmark in benchmarks:
         benchmark(  # type: ignore [call-arg]
             run_count=run_count,
-            col_widths=col_widths,
         )
 
 

src/shapefile.py

@@ -43,7 +43,6 @@
     Union,
     cast,
     overload,
-    runtime_checkable,
 )
 from urllib.error import HTTPError
 from urllib.parse import ParseResult, urlparse, urlunparse
@@ -141,14 +140,12 @@ class ReadableBinStream(Protocol):
     def read(self, size: int = -1) -> bytes: ...
 
 
-@runtime_checkable
 class WriteSeekableBinStream(Protocol):
     def write(self, b: bytes) -> int: ...
     def seek(self, offset: int, whence: int = 0) -> int: ...
     def tell(self) -> int: ...
 
 
-@runtime_checkable
 class ReadSeekableBinStream(Protocol):
     def seek(self, offset: int, whence: int = 0) -> int: ...
     def tell(self) -> int: ...
@@ -2220,16 +2217,6 @@ def _save_to_named_tmp_file(
     return tmp_file_obj
 
 
-# Minor hack.  Relies on Protocols being ABC subclasses.
-# They are currently ABCs anyway, so why not use that
-# for something useful like this?
-#
-# tempfile.NamedTemporaryFile is a dynamic wrapper
-# https://github.com/python/cpython/blob/2dd91d2b92a6c74d78cd3385ede328190cd8eaa9/Lib/tempfile.py#L510
-# so normal (naive) isinstance checks of tempfile.NamedTemporaryFiles
-# against @runtime_checkable Protocols are not possible.
-ReadSeekableBinStream.register(tempfile._TemporaryFileWrapper)
-
 HTML_SIGNATURES_UC = (
     b"<!DOCTYPE",
     b"<HTML",
@@ -2398,7 +2385,6 @@ def close(self) -> None:
         self.exit_stack.close()
 
 
-# TODO:  bound to @runtime_checkable Protocols
 FileProtoT = TypeVar("FileProtoT")
 
 
@@ -2479,9 +2465,17 @@ def _ensure_file_obj(
             exit_stack.enter_context(fp)
             return cast(FileProtoT, fp)
 
-        if isinstance(f, FileProto):
+        # Ugly, but we need to apply this to TemporaryFiles, and tempfile
+        # is a platform-inconsistent stick mess of dynamic wrappers,
+        # leading to weird Python 3.14 specific bug in run_benchmarks.py
+        # on Windows
+        attrs = FileProto.__protocol_attrs__  # type: ignore[attr-defined]
+
+        if all(hasattr(f, attr) for attr in attrs):
             return f
-        raise ExceptionClass(f"Unsupported file-like object: {f}")
+        raise ExceptionClass(
+            f"Unsupported file-like object: {f}.  Must satisfy: {FileProto}"
+        )
 
 
 class DbfReader(_FileChecker[ReadSeekableBinStream]):