Revamp pre-commit config to only built in hooks and local hooks

Run pre-commit using uv (it's in the lint group anyway)

Drop Pre-commit Github Actions cache

Add mypy pre-commit local repo hook

Pin mypy to 1.19.1 (last to support Python 3.9)

Try using uv to run mypy

Use uv to run pre-commit...  ...to run uv

uv sync before running pre-commit

Relock and add dependency cool down

Author: JamesParrott

.github/workflows/deploy.yml

@@ -13,13 +13,13 @@ on:
     types: [published]
 
 jobs:
-  format_type_check_lint_build_and_test:
+  run_checks_build_and_test:
     # Builds and uploads wheel and sdist
     uses: ./.github/workflows/run_checks_build_and_test.yml
 
   deploy:
     # Prevent deployment of releases that fail any tests or checks (e.g. linting).
-    needs: format_type_check_lint_build_and_test
+    needs: run_checks_build_and_test
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/run_checks_build_and_test.yml

@@ -13,47 +13,32 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v6
-    - uses: actions/setup-python@v6
+
+    - name: Install the latest version of uv and set the python version
+      uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
       with:
+        version: 0.11.15 # uv version
         python-version: "3.14"
 
-      ####################################################################
-      # "this action is in maintenance-only mode and will not be accepting new features."
-      # - uses: pre-commit/action@v3.0.1
-      #
-      # pre-commit/action does not intend to bump actions/cache from @v4:
-      # https://github.com/pre-commit/action/issues/241
-      # and has been stuck at @v3.0.1 for 2 years
-      #
-      # To bump actions/cache to v5 (to avoid the nuisance Node 20 deprecation
-      # warning) the action is vendored below:
-      #
-      # Copyright (c) 2019 Anthony Sottile.  MIT License.
-    - run: python -m pip install pre-commit
-      shell: bash
-    - run: python -m pip freeze --local
-      shell: bash
-    - uses: actions/cache@v5
-      with:
-        path: ~/.cache/pre-commit
-        key: pre-commit-3|${{ env.pythonLocation }}|${{ hashFiles('.pre-commit-config.yaml') }}
-    - run: pre-commit run --show-diff-on-failure --color=always ${{ inputs.extra_args }}
+    - name: uv Sync project, asserting locked with dev dependency group
+      run: uv sync --locked --group lint
+    - run: uv run pre-commit run --all-files --show-diff-on-failure --color=always ${{ inputs.extra_args }}
       shell: bash
-      #
-      #
-      #####################################################################
+
 
   mypy-strict:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v6
-    - uses: actions/setup-python@v6
+    - name: Install the latest version of uv and set the python version
+      uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
       with:
-        python-version: "3.13"
-    - name: Install mypy
-      run: pip install mypy
+        version: 0.11.15 # uv version
+        python-version: "3.14"
+
+      # use latest mypy version here, (even though pinned to 1.19.1 in lint group for Python 3.9 support)
     - name: Run mypy --strict
-      run: mypy --strict ./src/shapefile.py
+      run: uvx mypy --strict ./src/shapefile.py
 
 
   build_wheel_and_sdist:

.pre-commit-config.yaml

@@ -1,14 +1,32 @@
 repos:
-- repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.15.13
+- repo: local
   hooks:
-    # Run the linter
     - id: ruff-check
-      args: [ --fix ]
-    # Run the formatter
+      name: ruff check
+      entry: uv run ruff check
+      language: system
+      pass_filenames: false
     - id: ruff-format
+      name: ruff format
+      entry: uv run ruff format
+      language: system
+      pass_filenames: false
+    - id: mypy
+      name: mypy
+      entry: uv run mypy --strict .
+      language: system
+      pass_filenames: false
+# - repo: https://github.com/astral-sh/ruff-pre-commit
+#   rev: v0.15.13
+#   hooks:
+#     # Run the linter
+#     - id: ruff-check
+#       args: [ --fix ]
+#     # Run the formatter
+#     - id: ruff-format
 - repo: https://github.com/pre-commit/pre-commit-hooks
   rev: v6.0.0
   hooks:
     - id: check-yaml
     - id: trailing-whitespace
+

pyproject.toml

@@ -37,7 +37,7 @@ dev = [
     {include-group = "test"}
 ]
 lint = [
-    "mypy>=2.1.0",
+    "mypy==1.19.1", # last to support Python 3.9
     "pre-commit",
     "ruff",
 ]
@@ -48,14 +48,16 @@ test = [
 [project.urls]
 Repository = "https://github.com/GeospatialPython/pyshp"
 
-
+[tool.uv]
+exclude-newer = "1 week"
+exclude-newer-package = {pyshp = false, pyshp-stubs = false}
 
 [tool.mypy]
 files=["src/shapefile.py"]
 mypy_path = "src"
 explicit_package_bases = true
 exclude_gitignore = true
-exclude=[
+exclude=[  # Mypy requires regexes, not globs:
     'test_shapefile\.py',
     'run_benchmarks\.py',
 ]