Skip to content

fix: update key comparison in http_request to be case-insensitive #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruslanti merged 1 commit into from
May 14, 2026
Merged

fix: update key comparison in http_request to be case-insensitive #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nginx_module/src/http_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ impl<'a> HeaderList<'a> {
std::slice::from_raw_parts_mut(part.elts as *mut ngx_table_elt_t, part.nelts)
};
for elem in elems {
if unsafe { NgxStr::from_raw(elem.key) } == name {
if unsafe { NgxStr::from_raw(elem.key) }.eq_ignore_ascii_case(&name) {
elem.value = value.inner();
}
}
Expand Down
4 changes: 4 additions & 0 deletions nginx_module/src/ngx_str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ impl<'a> NgxStr<'a> {
pub const fn is_empty(self) -> bool {
self.inner.len == 0
}

pub fn eq_ignore_ascii_case(self, other: &NgxStr<'_>) -> bool {
self.as_bytes().eq_ignore_ascii_case(other.as_bytes())
}
}

impl<'a> Builder<'a> {
Expand Down