fix: update key comparison in http_request to be case-insensitive#23
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates HTTP header key matching to be case-insensitive (per HTTP semantics) by adding a case-insensitive comparison helper on NgxStr and using it in HeaderList::set.
Changes:
- Add
NgxStr::eq_ignore_ascii_casefor ASCII case-insensitive byte comparisons. - Update
HeaderList::setto match header names case-insensitively when updating values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nginx_module/src/ngx_str.rs | Adds a helper to compare NgxStr values ignoring ASCII case. |
| nginx_module/src/http_request.rs | Uses the new helper so header updates/removals match keys case-insensitively. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.