Improve error gestion and add support for promise for loading plugins

Author: SamyPesse

lib/application.js

@@ -50,7 +50,11 @@ var Application = function(config, basePlugins) {
                 // Emit event
                 that.emit("plugin", plugin);
             });
-        }, Q({}));
+        }, Q({})).fail(function(err) {
+            // Emit error
+            that.emit("error", err);
+            return Q.reject(err);
+        });
     };
 
     // Check dependencies

lib/plugin.js

@@ -21,28 +21,38 @@ var Plugin = function(config, app) {
         }
 
         var register = function(err, services) {
-            if (err) return that.emit("error", err);
+            if (err) {
+                deferred.reject(err);
+                return;
+            }
 
             // check services provided
+            var failed = false;
             _.each(that.provides, function(toProvide) {
                 if (!services[toProvide]) {
                     var err = new Error("Plugin failed to provide " + toProvide + " service.");
-                    that.emit("error", err);
+                    failed = true;
                     deferred.reject(err);
                     return;
                 }
                 that.app.services[toProvide] = services[toProvide];
 
                 that.app.emit("service", toProvide, services[toProvide]);
             });
-            deferred.resolve(that);
-        }
+            if (!failed) deferred.resolve(that);
+        };
 
         var setup = require(that.packagePath);
         try {
-            setup(that, imports, register, that.app);
+            var r = setup(that, imports, register, that.app);
+            if (Q.isPromise(r)) {
+                r.then(function(provides) {
+                    register(null, provides);
+                }, function(err) {
+                    register(err);
+                });
+            }
         } catch(e) {
-            app.emit("error", e);
             deferred.reject(e);
         }
 

package.json

@@ -1,7 +1,7 @@
 {
     "name": "engineer",
     "description": "Powerful plugin system for writing large and extensible NodeJS applications",
-    "version": "0.0.8",
+    "version": "0.0.9",
     "author": "FriendCode <contact@friendco.de>",
     "contributors": [
         {