-
Notifications
You must be signed in to change notification settings - Fork 0
Description
We need to discuss the use of keywords for linking issues that are closed by commits, and confirm whether Flowing Code Commit Message Guidelines / 1.0.0-rc.8 aligns with our current practice.
-
According to the Guidelines, the commit message footer to be used for linking the issue that is closed by the commit is
Close #. GitHub supports other keywords (closes,closed,fix,fixes,fixed,resolve,resolvesandresolved). In some cases other keywords have been used. It seems we don't have a strong feeling about this point (and requesting changes in a PR just because they used the "wrong" footer seems too pedantic) -
GitHub also allows the keyword to be followed by colons (e.g.
Closes: #) while the Guidelines do not allow that syntax. -
Both GitHub and the Guidelines specify that the keywords are case-insensitive, while common practice seems to be capitalizing only the first letter.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status