Skip to content

Should Terminology Service exceptions ever be considered a succes result? #537

@ewoutkramer

Description

@ewoutkramer

To quote from #534:

  • Our local terminology service raises a an exception when expansion fails.
  • In BindingValidator.callService(), an exception thrown by the invocation of a terminology service results in a Warning Assertion, unless the callback to HandleValidateCodeServiceFailure (settable in the validation settings) dictates otherwise.
  • IssueAssertion's of level warning are turned into a successful validation result (see constructor of IssueAssertion)
  • When the BindingValidator is called in the context of a slice bucket discriminator, a succesful result means the instance fits the bucket.

TL;DR: expansion errors on a bucket discriminator will make everything match that discriminator.

I feel that turning every exception here into a warning is the weak link - but I am not sure. This might be a good place to use a result of Undecided instead of success, but that will probably create regressions where a weak warning should be considered a success.

But something needs to be changed, that's for sure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions