Modloader
Forge
Minecraft version
1.20.1
Hex Casting version
0.11.3
Issue description
The full inventory drop used by MishapNoSpellCircle is implemented directly in that class rather than delegating to the MishapEnvironment. Consequently, if a casting env that uses a mishap env other than the standard PlayerMishapEnv triggers MishapNoSpellCircle, it will still cause the casting player to drop their inventory with no way to override that behavior.
Notably, the WispMishapEnv used by Hexal’s wisps overrides all the MishapEnvironment effects to be no-ops, so most mishaps do nothing when triggered by a wisp apart from killing the wisp. However, this does not apply to the MishapNoSpellCircle effect for the reasons described above, meaning that a wisp trying to cast circle-only patterns will cause its owner to drop their entire inventory.
This also means that anyone who wants to use the full-inv-drop effect for their own mishaps needs to entirely reimplement it, rather than being able to simply call the relevant MishapEnvironment method.
Modloader
Forge
Minecraft version
1.20.1
Hex Casting version
0.11.3
Issue description
The full inventory drop used by MishapNoSpellCircle is implemented directly in that class rather than delegating to the MishapEnvironment. Consequently, if a casting env that uses a mishap env other than the standard PlayerMishapEnv triggers MishapNoSpellCircle, it will still cause the casting player to drop their inventory with no way to override that behavior.
Notably, the WispMishapEnv used by Hexal’s wisps overrides all the MishapEnvironment effects to be no-ops, so most mishaps do nothing when triggered by a wisp apart from killing the wisp. However, this does not apply to the MishapNoSpellCircle effect for the reasons described above, meaning that a wisp trying to cast circle-only patterns will cause its owner to drop their entire inventory.
This also means that anyone who wants to use the full-inv-drop effect for their own mishaps needs to entirely reimplement it, rather than being able to simply call the relevant MishapEnvironment method.