[$250] [Exploratory] Reports - Modal closes when clicking Next during action flow

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.44-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85530
Email or phone of affected tester (no customers): applausetester+ap3@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11
App Component: Other

Action Performed:

Preconditions
Fresh account or cache cleared
At least 9 reports with different expense states (Rejected, Approved, Submitted, Held, Duplicated)

1.Open staging.newexpensify.com
2.Navigate to Reports
3.Refresh the Reports page
4.Open any report
5.Click the "Next" button repeatedly until the modal closes

Expected Result:

The modal navigates through all expenses without closing unexpectedly.

Actual Result:

The modal closes unexpectedly after clicking "Next" during initial attempts after refreshing the page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ahmedGaber93

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022044065854848242190
• Upwork Job ID: 2044065854848242190
• Last Price Increase: 2026-04-21

[MelvinBot]

Issue Analysis

Root Cause: In SearchMoneyRequestReportPage.tsx (lines 93–110), a removal-detection useEffect dismisses the modal when report becomes undefined while the previous render had a money request report. During Next/Prev arrow navigation, the route params update before Onyx resolves the new report data, creating a brief window where report is undefined — which the effect misinterprets as a deletion and calls Navigation.dismissModal().

This is exacerbated after a page refresh because Onyx data loads asynchronously, making the undefined window longer and more likely to be hit by rapid clicks.

Likely Duplicate: This appears to be the same bug as #87784 ("RHP closes unexpectedly when navigating between expense reports using prev/next arrows"), which already has an identified root cause and is being worked on.

Recommended Fix: The removal-detection effect needs to distinguish between "report was deleted" and "route params changed and new report data hasn't loaded yet." One approach is to also check whether the reportID in route params changed — if it did, the undefined state is expected (navigation in progress) and dismissal should be skipped.

Investigation details

The relevant code is in App/src/pages/Search/SearchMoneyRequestReportPage.tsx:

// Lines 93-110
useEffect(() => {
    if (firstRenderRef.current) {
        firstRenderRef.current = false;
        return;
    }
    const isRemovalExpectedForReportType = !report && isMoneyRequestReport(prevReport);
    if (isRemovalExpectedForReportType) {
        if (!isFocused) {
            return;
        }
        Navigation.dismissModal();
    }
}, [report, isFocused, prevReport]);

The firstRenderRef guard only protects against the initial mount. It does not protect against subsequent navigations where the reportID changes but Onyx hasn't yet resolved the new report data.

---

Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)