[$250] Wrong onboarding tasks, and displayed twice in the Concierge chat

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.24-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82679
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome, Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus
App Component: Other

Action Performed:

Preconditions:

1. User A is a new user created on https://staging.expensify.com/ by selecting "Organize my own expenses". The "Get paid back from my employer" option was selected from the intent selector during the onboarding flow.
2. In NewDot, change the default currency to USD
3. Click FAB > Start chat to a non-existent account (User B) > Create an expense via User B's chat

Steps:

1. Go to User B's email inbox
2. From the email with the subject "Please pay expense", copy the link "open it in Expensify"
3. Paste to new tab, change the link to staging and navigate to it
4. Go to the expense details
5. Tap on Pay $X.XX > Pay with business account
6. Tap on Log into your bank account
7. Complete the Plaid flow
8. Approve the expense
9. Tap on Pay $X.XX
10. Navigate to the Concierge chat

Expected Result:

Verify that the onboarding tasks are displayed for manage my team expenses

Actual Result:

Wrong onboarding tasks were displayed twice in the Concierge chat
Note:

• Chat and split expense onboarding task is displayed twice

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ChavdaSachin

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022025495191640841188
• Upwork Job ID: 2025495191640841188
• Last Price Increase: 2026-03-09

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ChavdaSachin (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022025495191640841188

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an invited user (User B) goes through the payment flow after receiving an expense from User A, onboarding tasks appear twice in the Concierge chat, and the wrong onboarding tasks are shown ("Chat and split expense" tasks instead of "Manage my team expenses" tasks).

What is the root cause of that problem?

There are two separate bugs producing this behavior:

Bug 1 -- Duplicate tasks: completePaymentOnboarding() (IOU/index.ts:11893) can be called multiple times during a single payment flow because its dedup guard (isInviteOnboardingComplete) is never set by the code path it triggers. Specifically:

1. completePaymentOnboarding is called from BaseKYCWall.tsx:170 when the user selects "Pay with business account" and a workspace is created
2. It's called again from payMoneyRequest at IOU/index.ts:11941 when the user completes the actual payment
3. Each call goes through completeOnboarding() -> prepareOnboardingOnyxData(), which generates new random reportActionIDs and MERGEs them into the Concierge chat's report actions via Onyx.METHOD.MERGE
4. The isInviteOnboardingComplete flag (checked at IOU/index.ts:11901) is only set by the openReport path at Report/index.ts:1347, not by completeOnboarding. And hasCompletedGuidedSetupFlow is skipped because wasInvited: true is always passed (ReportUtils.ts:11791-11797). So consecutive calls are not blocked.

Bug 2 -- Wrong tasks: There is also a cross-path conflict between openReport() and completePaymentOnboarding(). The openReport path at Report/index.ts:1323 can generate onboarding tasks using the user's introSelected.choice (e.g., CHAT_SPLIT for chat-invited users). Meanwhile, completePaymentOnboarding overrides the choice to MANAGE_TEAM when paymentSelected === BBA (IOU/index.ts:11909-11910). The dedup between these paths is incomplete -- openReport only checks for other OPEN_REPORT commands in the persisted request queue (Report/index.ts:1319), not for COMPLETE_GUIDED_SETUP commands. This means both paths can fire, producing CHAT_SPLIT tasks from openReport AND MANAGE_TEAM tasks from completePaymentOnboarding.

This issue was made more visible by PR #82679, which fixed a different bug (missing tasks) by changing the default value of selectedInterestedFeatures from [] to undefined in completeOnboarding(). Before that fix, most MANAGE_TEAM tasks were incorrectly filtered out, masking the duplication. After the fix, all tasks are properly included, making the duplicates obvious.

What changes do you think we should make in order to solve the problem?

The fix should ensure completeOnboarding() sets the isInviteOnboardingComplete flag in its optimistic data when wasInvited is true, preventing subsequent calls from completePaymentOnboarding from creating duplicate tasks.

In prepareOnboardingOnyxData() at ReportUtils.ts:11791, add an optimistic update to set isInviteOnboardingComplete: true on NVP_INTRO_SELECTED when wasInvited is true. Currently this block only handles !wasInvited; the wasInvited case should mirror what openReport does at Report/index.ts:1347.

Additionally, the hasOpenReportWithGuidedSetupData check in openReport() at Report/index.ts:1319 should be expanded to also check for pending COMPLETE_GUIDED_SETUP commands, preventing the cross-path duplication.

What alternative solutions did you explore? (Optional)

An alternative would be to add a guard at the top of completeOnboarding() that checks hasCompletedGuidedSetupFlow or isInviteOnboardingComplete before proceeding. However, the more targeted fix of setting isInviteOnboardingComplete in the optimistic data is cleaner because it uses the existing dedup mechanism and prevents the race at its source.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[jjcoffee]

@nkdengineer Could you take a look at this as a possible regression from #82679?

[nkdengineer]

This issue was made more visible by PR #82679, which fixed a different bug (missing tasks) by changing the default value of selectedInterestedFeatures from [] to undefined in completeOnboarding(). Before that fix, most MANAGE_TEAM tasks were incorrectly filtered out, masking the duplication. After the fix, all tasks are properly included, making the duplicates obvious.

Based on the bot proposal, I think it's not our regression.