Workflow - Invite page reopens after inviting submitter and reselecting approver

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.91-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75589
Email or phone of affected tester (no customers): sjdoinjsdoijsiojdsio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Admin has invited User B to the workspace.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Click Add approval workflow.
4. Create a new workflow where Owner submits to User B.
5. Click on the new workflow.
6. Click Expenses from.
7. Enter User C email > select it > Next.
8. Click Invite.
9. Select User C.

Expected Result:

App will return to confirm page.

Actual Result:

App reopens invite page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7040499_1767351638944.3.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #75589

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflow - Invite page reopens after inviting submitter and reselecting approver

What is the root cause of that problem?

After inviting a new user and clicking "Invite", the app needs to determine whether this is part of the initial workflow creation flow or an edit flow. The logic used to make this determination

App/src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

Lines 180 to 181 in 634b5ce

	const backToStr = typeof backTo === 'string' ? backTo : '';
	const isInitialCreationFlow = !backToStr.includes('/expenses-from/');

The backTo URL during initial creation is expenses-from, which DOES contain expenses-from, causing the check to incorrectly identify this as an edit flow rather than initial creation flow. This results in Navigation.goBack() being called instead of navigating to the approver screen, which reopens the expenses-from (invite) page.

What changes do you think we should make in order to solve the problem?

We should change the detection logic to check for the presence of a nested backTo parameter instead of checking for the string /expenses-from/:

const isInitialCreationFlow = !backToStr.includes('backTo=');

App/src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

Lines 180 to 181 in 634b5ce

	const backToStr = typeof backTo === 'string' ? backTo : '';
	const isInitialCreationFlow = !backToStr.includes('/expenses-from/');

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.