Skip to content

Commit 8b587eb

Browse files
committed
Added ref modifier on SciterValue to window variable methods
1 parent 26be9f0 commit 8b587eb

3 files changed

Lines changed: 8 additions & 13 deletions

File tree

src/EmptyFlow.SciterAPI/Client/HostValueAPI.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ public SciterValue ValueInvoke ( ref SciterValue value, SciterValue? context, IE
229229
/// </summary>
230230
/// <returns>Return element.</returns>
231231
/// <exception cref="Exception">If Result will be not zero it will be part of error message.</exception>
232-
public nint ElementFromValue ( SciterValue sciterValue ) {
232+
public nint ElementFromValue ( ref SciterValue sciterValue ) {
233233
var pointer = nint.Zero;
234234
var domResult = m_basicApi.SciterElementUnwrap ( sciterValue, ref pointer );
235235
if ( domResult != 0 ) throw new Exception ( $"Can't get element from value. DomResult is {domResult}" );
@@ -255,15 +255,15 @@ public SciterValue ElementToValue ( nint element ) {
255255
/// <summary>
256256
/// Sets variable that will be available in each document loaded after this call.
257257
/// </summary>
258-
public void SetSharedVariable ( string name, SciterValue value ) {
258+
public void SetSharedVariable ( string name, ref SciterValue value ) {
259259
var code = m_basicApi.SciterSetVariable ( nint.Zero, name, value );
260260
if ( code != (uint) DomResult.SCDOM_OK ) throw new Exception ( $"Can't set variable {name}. Error is {code}." );
261261
}
262262

263263
/// <summary>
264264
/// Sets variable that will be available in root document of main window, call it in or after DOCUMENT_CREATED event.
265265
/// </summary>
266-
public void SetMainWindowVariable ( string name, SciterValue value ) {
266+
public void SetMainWindowVariable ( string name, ref SciterValue value ) {
267267
var code = m_basicApi.SciterSetVariable ( m_mainWindow, name, value );
268268
if ( code != (uint) DomResult.SCDOM_OK ) throw new Exception ( $"Can't set variable {name}. Error is {code}." );
269269
}

src/EmptyFlow.SciterAPI/Client/HostWindowsAPI.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public nint GetWindowFocus ( nint window ) {
362362
if ( m_basicApi.SciterEval ( window, script, (uint) script.Length, out var result ) ) {
363363
if ( result.IsNull ) return nint.Zero;
364364

365-
return ElementFromValue ( result );
365+
return ElementFromValue ( ref result );
366366
}
367367

368368
return nint.Zero;
@@ -373,7 +373,7 @@ public nint GetWindowParent ( nint window ) {
373373
if ( m_basicApi.SciterEval ( window, script, (uint) script.Length, out var result ) ) {
374374
if ( result.IsNull ) return nint.Zero;
375375

376-
return ElementFromValue ( result );
376+
return ElementFromValue ( ref result );
377377
}
378378

379379
return nint.Zero;

src/EmptyFlow.SciterAPI/EmptyFlow.SciterAPI.csproj

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,9 @@
2121
<Version>1.2.4.0</Version>
2222
<PackageLicenseFile>LICENSE</PackageLicenseFile>
2323
<PackageReleaseNotes>
24-
IPseudoSomModel.SetUnique for set model unique identifier
25-
IPseudoSomModel.Unique for get model unique identifier
26-
SciterEventHandler.SetReturnState for some handlers it required to change return state
27-
WindowEventHandler now obsolete, it redundant class please use SciterEventHandler instead in all cases
28-
SciterAPIHost.AddWindowEventHandler added argument behaviours for change tracked behaviours
29-
SciterAPIHost.UpdateElement for (re)render element
30-
SciterAPIHost.ScrollToElement scroll to element
31-
Fixed issue in showing different from main windows
24+
SciterAPIHost.ElementFromValue first argument now have ref modificator
25+
SciterAPIHost.SetSharedVariable argument value now have ref modificator
26+
SciterAPIHost.SetMainWindowVariable argument value now have ref modificator
3227
</PackageReleaseNotes>
3328
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
3429
</PropertyGroup>

0 commit comments

Comments
 (0)