Hi, I wanted to clarify the intended score semantics for Drive goal_behavior=0 on the default branch.
The docs say respawn mode ignores post-respawn collisions, which I interpret as: pre-goal collision/off-road should still disqualify success, but failures after the first goal/respawn should not.
In the current default branch, though, respawn_agent() resets collided_before_goal, while add_log() uses collided_before_goal for score in GOAL_RESPAWN mode. This seems to allow a pre-goal collision to be cleared after reaching the goal and respawning, so the final score can still be 1.
Is that intended, or should pre-goal failure persist until logging?
Hi, I wanted to clarify the intended
scoresemantics for Drivegoal_behavior=0on the default branch.The docs say respawn mode ignores post-respawn collisions, which I interpret as: pre-goal collision/off-road should still disqualify success, but failures after the first goal/respawn should not.
In the current default branch, though,
respawn_agent()resetscollided_before_goal, whileadd_log()usescollided_before_goalforscoreinGOAL_RESPAWNmode. This seems to allow a pre-goal collision to be cleared after reaching the goal and respawning, so the finalscorecan still be 1.Is that intended, or should pre-goal failure persist until logging?