chore(parse_sitemap): renaming get_sources to parse_sitemap

Author: kennethrioja

lib/ingestors/concerns/sitemap_helpers.rb

@@ -6,7 +6,7 @@ module Concerns
     module SitemapHelpers
       private
 
-      def get_sources(source_url)
+      def parse_sitemap(source_url)
         case source_url.downcase
         when /sitemap(.*)?\.xml\Z/
           parse_xml_sitemap(source_url)

lib/ingestors/github_ingestor.rb

@@ -41,7 +41,7 @@ def self.config
     def read(source_url)
       @verbose = false
       # Returns either a map of unique URL entries, either the URL itself
-      sources = get_sources(source_url)
+      sources = parse_sitemap(source_url)
 
       sources.each do |url|
         # Reads each source, if github.{com|io}, gets the repo's api, if not, next

test/helpers/sitemap_helper_test.rb

@@ -6,12 +6,12 @@ class SitemapHelperTest < ActionView::TestCase
     @messages = []
   end
 
-  test 'get_sources with url only returns url only' do
+  test 'parse_sitemap with url only returns url only' do
     url = 'https://test.com'
-    assert_equal @ingestor.send(:get_sources, url), [url]
+    assert_equal @ingestor.send(:parse_sitemap, url), [url]
   end
 
-  test 'get_sources returns parsed URLs from sitemap.xml' do
+  test 'parse_sitemap returns parsed URLs from sitemap.xml' do
     sitemap_xml = <<~XML
       <?xml version="1.0" encoding="UTF-8"?>
       <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
@@ -27,11 +27,11 @@ class SitemapHelperTest < ActionView::TestCase
     stub_request(:get, 'https://app.com/events/sitemap.xml')
       .to_return(status: 200, body: sitemap_xml, headers: { 'Content-Type' => 'application/xml' })
 
-    urls = @ingestor.send(:get_sources, 'https://app.com/events/sitemap.xml')
+    urls = @ingestor.send(:parse_sitemap, 'https://app.com/events/sitemap.xml')
     assert_equal ['https://app.com/events/123', 'https://app.com/events/456'], urls
   end
 
-  test 'get_sources returns parsed URLs from sitemap.txt' do
+  test 'parse_sitemap returns parsed URLs from sitemap.txt' do
     sitemap_txt = <<~TXT
       https://app.com/events/123
       https://app.com/events/456
@@ -40,7 +40,7 @@ class SitemapHelperTest < ActionView::TestCase
     stub_request(:get, 'https://app.com/events/sitemap.txt')
       .to_return(status: 200, body: sitemap_txt, headers: { 'Content-Type' => 'txt' })
 
-    urls = @ingestor.send(:get_sources, 'https://app.com/events/sitemap.txt')
+    urls = @ingestor.send(:parse_sitemap, 'https://app.com/events/sitemap.txt')
     assert_equal ['https://app.com/events/123', 'https://app.com/events/456'], urls
   end
 

test/test_helper.rb

@@ -411,7 +411,7 @@ def self.config
     end
 
     def read(url)
-      get_sources(url)
+      parse_sitemap(url)
       open_url(url)
     end
   end

test/unit/ingestors/github_ingestor_test.rb

@@ -321,7 +321,7 @@ def materials
   end
 
   test 'std errors when exception is raised' do
-    @ingestor.stub(:get_sources, ->(*) { raise StandardError, 'test failure' }) do
+    @ingestor.stub(:parse_sitemap, ->(*) { raise StandardError, 'test failure' }) do
       mock_logger = Minitest::Mock.new
       mock_logger.expect(:error, nil, ['StandardError: read() failed, test failure'])