Add MYNN PBL scheme to convection-permitting physics suite#397
Open
kuanchihwang wants to merge 13 commits into
Open
Add MYNN PBL scheme to convection-permitting physics suite#397kuanchihwang wants to merge 13 commits into
kuanchihwang wants to merge 13 commits into
Conversation
…ayer scheme Also fix incorrect units.
It is a duplicate of `qfx` in MYNN surface layer scheme.
`spp_pbl` is an integer model control variable in MPAS. Make it consistent with MPAS here.
The `diagnostic_name` API from the constituent object should be used to get the diagnostic name instead of by truncating the standard name. Consider the following two constituents: * mass_number_concentration_of_cloud_liquid_water_particles_in_air * mass_number_concentration_of_cloud_ice_water_crystals_in_air By truncating their standard names to 32 characters, both will appear to have the same diagnostic name, "mass_number_concentration_of_clo". This will crash the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name
TBD
Originator(s)
kuanchihwang
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number)
This PR adds MYNN PBL scheme to convection-permitting physics suite.
Additionally, an issue with the
sima_state_diagnosticsscheme has been identified and fixed. Consider the following two constituents for example:The
sima_state_diagnosticsscheme adds constituents to history output by truncating their standard names to 32 characters. However, by doing so, both constituents will appear to have the same diagnostic name, "mass_number_concentration_of_clo". This issue will cause the model to crash.Use the proper
diagnostic_nameAPI from the constituent object instead to fix it.List all namelist files that have been modified
None
List all files eliminated and why
None
List all files added and what they do
List all existing files that have been modified, and describe the changes
List all automated tests that failed, as well as an explanation for why they were not fixed
None
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes, but only for convection-permitting physics suite.
If yes to the above question, describe how this code was validated with the new/modified features
Configure, build, and run CAM-SIMA with the
MPASCPcompset.