Skip to content

Campaign Deputy Templates#1137

Open
joshbartley wants to merge 7 commits into
Domain-Connect:masterfrom
joshbartley:campaigndeputy-templates
Open

Campaign Deputy Templates#1137
joshbartley wants to merge 7 commits into
Domain-Connect:masterfrom
joshbartley:campaigndeputy-templates

Conversation

@joshbartley
Copy link
Copy Markdown

@joshbartley joshbartley commented May 22, 2026

Description

DNS records for Campaign Deputy's email authentication, and CRM features. Two templates, one using NS Delegation, and another for DNS providers that don't support NS delegation. Optional dns records using groups based on client configuration.

Note: These DNS records are only for an apex domain.

Type of change

Please mark options that are relevant.

  • New template
  • [] Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):
Test campaigndeputy.app/email-full example.com/@

Test campaigndeputy.app/email-delegated example.com/@

Test campaigndeputy.app/email-full example.com/host

Test campaigndeputy.app/email-delegated example.com/host

@github-actions github-actions Bot added the Test links missing No test links from Online Editor provided label May 22, 2026
@github-actions
Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions
Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions
Copy link
Copy Markdown

Linter OK

campaigndeputy.app.email-delegated.json

Level Code Note
info DCTL1032 mix of empty and defined record groupId values

campaigndeputy.app.email-full.json

Level Code Note
info DCTL1032 mix of empty and defined record groupId values

@joshbartley joshbartley changed the title Campaigndeputy templates Campaign Deputy Templates May 22, 2026
@github-actions github-actions Bot removed the Test links missing No test links from Online Editor provided label May 22, 2026
@github-actions
Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/3 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 9/10 checkboxes ticked
  OK  Online Editor test results: 4 link(s) found
  OK  Template coverage: all 2 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant