Add DeepCurrent Mailgun outreach template#1127
Open
ulmoai wants to merge 1 commit into
Open
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the DeepCurrent managed email Domain Connect template.
This template configures a selected sending subdomain for outbound email through DeepCurrent's managed Mailgun/Smartlead infrastructure.
Type of change
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC); no TXT records requiring unique conflict matching are included@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC); no such end-user-modified records are includedOnline Editor test results
Editor test link(s):
No signed Online Editor token link is available yet.
The editor redirected to provisioned OIDC login and returned a server error from this validation session. No forged editor link is included.
Template
deepcurrent.appmailgun-outreachdeepcurrent.app.mailgun-outreach.jsonDNS Records
The template uses the standard Domain Connect
hostapply parameter for selected sending subdomains. It does not use a custom host variable.Signing
syncPubKeyDomain:domainconnect.deepcurrent.app_dcpubkeyv1Validation
dc-template-linter -cloudflare -logos: passedLinter note:
DCTL5003 syncRedirectDomain is not supported. Cloudflare documents this as ignored for its implementation.Live DNS / Mailgun Test
The template values were manually applied to an isolated test domain,
outreach-test.deepcurrent.app, without touching existing production outreach domains or Smartlead campaigns.Mailgun verification result:
activevalidvalidvalidvalidvalidNotes
Human replies are handled by the configured reply-to mailbox in DeepCurrent/Smartlead. The Mailgun MX records are scoped to the sending subdomain and match the current production Mailgun setup pattern.