Skip to content

Workflows cli create cmd issues #1288

@hazdl

Description

@hazdl

Got 4 bugs:
1- Treating a YAML file as a directory name
eg: workflows create hello_cli_test.yaml
the program creates a directory named : hello_cli_test.yaml

2- Missing source directories are NOT treated as errors
It is assumed that these are always present :
workflow_home/template-boilerplate/conventional-templates
workflow_home/template-boilerplate/helm-based-templates

But in the instuled model they dont exist: fs::read_dir(src)

3- Errors are swallowed instead of propagated
The copy_directory function, prints ERRORS, returns, and Never signal a failure
generate_template_repo always returns Ok(())

4- User is prompted before prerequisites are validated
eg: ould you like to store conventional WorkflowTemplate manifests? Y
Operation cannot possibly succeed because there is no template, so it should check before asking.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions