performance/optimizations

[vutran]

TBD.

[z3t0]

do we have any way to measure profile performance?

[vutran]

Not at the moment but am open for any thoughts/suggestions on how we can do this.

[z3t0]

Okay then I'll take a look into this. Also I noticed that it lags when typing is that intentional?

[brpaz]

Yeah, noticed that lag also.

[vutran]

I believe I had debounced the query function for a few milliseconds a while back. I'm open for any suggestions on perf.

[z3t0]

I guess the first step is to figure out some way to quantitatively profile performance.

I'm still trying to figure out how the build process works, for example what is the purpose of webpack?

The app seems to run a lot faster and without type lag when just doing electron . im not sure why?
@brpaz can you try doing the same where you run it off electron directly?

Also I might just be making things up in my confusion so let me know if all of this is just circumstantial

[vutran]

webpack is primarily used for transpile the renderer bundle mainly for ES6 imports + JSX.

(Note: app/renderer/src transpiles to app/renderer/lib/bundle.js which is loaded in app/renderer/index.html.)

The main process is not transpiled as it is using currently available Node features.

Also, there's a 500ms debounce (here) for handling multiple queries. We can definitely lower to something more appropriate.

Are you running in dev or the build?

[z3t0]

Also, there's a 500ms debounce (here) for handling multiple queries. We can definitely lower to something more appropriate.

Is the debounce for the query being processed, or typing into the bar itself? Because the lag isn't for the query but rather when typing.

Are you running in dev or the build?

Not too sure, I'm just running electron . --debug in the root of the project?

[vutran]

The denounce is to query. We may want to move that higher to the renderer so it doesn't hit the IPC calls.

[z3t0]

The denounce is to query. We may want to move that higher to the renderer so it doesn't hit the IPC calls.

Oh I see, I'm still not sure however why just running electron . --debug does not cause a typing lag?

[mrjohnyhats]

Maybe this was just fixed since November, but I don't notice any lag at all when I'm using electron ., so if we launch the app for users with that, performance should be fine.