DevToys.Extensions.FluentIconFinder

[pierre3]

Thank you for the wonderful tool!

I am currently trying to create an extension for DevToys.
Since it was difficult to find the glyphs of FluentSystemIcons available by default, I created an extension that allows for easy searching.

https://github.com/pierre3/DevToys.Extensions.FluentIconFinder
I would appreciate any feedback.

I would like to share some issues I noticed during implementation.

1. The timing of the DataGrid’s OnRowSelected event seems to be off.
   • No response on the first click.
   • On the second click, the information of the row clicked on the first click is retrieved.
   • Additionally, after the first click, if I click on an area outside the DataGrid, the event is triggered.
2. Since the glyph that can be specified in the Icon is of type char, surrogate pair icons cannot be specified.

[veler]

Hi,
This is an awesome idea and well executed! Thank you for your feedback on the DataGrid.

If that's OK, I will add a link to this extension in the DevToys documentation. Here is how it looks on my local machine currently.

[pierre3]

Thank you for your reply.

Currently, Fluent UI Icon has about 8,100 icons, but approximately 1,600 of them have Glyph values that exceed the 2-byte limit (65535). As a result, these 1,600 icons cannot be used with the current implementation.

FluentSystemIcons-Regular.json
https://github.com/microsoft/fluentui-system-icons/blob/38a6f9837c2d45018678cb38668ebff83763fe58/fonts/FluentSystemIcons-Regular.json#L6398

Additionally, since the remaining information is lost when passed as a char type argument, it would be difficult to detect and adjust surrogate characters in the internal implementation.

[veler]

Ah, yes, that makes sense! And indeed, we can't use char because we may lose some information. I see that in your proposal you use int instead of char, which makes sense.
I'm wondering now if, from API perspective, we could just do 2 endpoints like this:

public static partial class GUI
{
    public static IUIIcon Icon(string fontName, char glyph)
    {
        return Icon(id: null, fontName, glyph);
    }

    // Note how the method name doesn't mention `32`.
    public static IUIIcon32 Icon(string fontName, int glyph)
    {
        return Icon32(id: null, fontName, glyph);
    }
}

That could potentially make it more smooth for extension developers. Also, perhaps IUIIcon32 could inherits from IUIIcon or vice versa, whatever's simpler.

[pierre3]

Thank you for the suggestion! Your proposed implementation is indeed more elegant. I’ll try making the changes along with implementing the inheritance from IUIIcon. Once the implementation is done, I’ll create a Pull Request, so please wait for it.

[veler]

Thank you very much! Appreciate :D

[jerone]

That could potentially make it more smooth for extension developers.

This will indeed make it backwards-compatible for existing extensions.

[pierre3]

@veler
I have created a pull request. Please review the changes.

#1435