Skip to content

Commit ea8b2a8

Browse files
committed
chore: linter fixes
1 parent f4420a1 commit ea8b2a8

File tree

10 files changed

+78
-52
lines changed

10 files changed

+78
-52
lines changed

devcycle_python_sdk/models/config_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ def from_json(json_str: str) -> "ConfigMetadata":
2222
return ConfigMetadata(
2323
project=ProjectMetadata.from_json(json_str["project"]),
2424
environment=EnvironmentMetadata.from_json(json_str["environment"]),
25-
)
25+
)

devcycle_python_sdk/models/environment_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ def from_json(json_str: str) -> "EnvironmentMetadata":
1414
return EnvironmentMetadata(
1515
id=json_str["id"],
1616
key=json_str["key"],
17-
)
17+
)

devcycle_python_sdk/models/eval_hook_context.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,15 @@
33
from devcycle_python_sdk.models.user import DevCycleUser
44
from devcycle_python_sdk.models.config_metadata import ConfigMetadata
55

6+
67
class HookContext:
7-
def __init__(self, key: str, user: DevCycleUser, default_value: Any, config_metadata: ConfigMetadata = None):
8+
def __init__(
9+
self,
10+
key: str,
11+
user: DevCycleUser,
12+
default_value: Any,
13+
config_metadata: ConfigMetadata = None,
14+
):
815
self.key = key
916
self.default_value = default_value
1017
self.user = user

devcycle_python_sdk/models/project_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ def from_json(json_str: str) -> "ProjectMetadata":
1414
return ProjectMetadata(
1515
id=json_str["id"],
1616
key=json_str["key"],
17-
)
17+
)

devcycle_python_sdk/options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def __init__(
9090

9191
if self.event_request_chunk_size > self.max_event_queue_size:
9292
logger.warning(
93-
f"DevCycle: event_request_chunk_size: {self.event_request_chunk_size} must be smaller than max_event_queue_size: { self.max_event_queue_size}"
93+
f"DevCycle: event_request_chunk_size: {self.event_request_chunk_size} must be smaller than max_event_queue_size: {self.max_event_queue_size}"
9494
)
9595
self.event_request_chunk_size = 100
9696

devcycle_python_sdk/protobuf/utils.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,17 @@ def create_nullable_custom_data(val: Optional[dict]) -> pb2.NullableCustomData:
3434
if value is None:
3535
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Null) # type: ignore
3636
elif isinstance(value, bool):
37-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Bool, boolValue=value) # type: ignore
37+
values[key] = pb2.CustomDataValue(
38+
type=pb2.CustomDataType.Bool, boolValue=value
39+
) # type: ignore
3840
elif isinstance(value, str):
39-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Str, stringValue=value) # type: ignore
41+
values[key] = pb2.CustomDataValue(
42+
type=pb2.CustomDataType.Str, stringValue=value
43+
) # type: ignore
4044
elif isinstance(value, (int, float)):
41-
values[key] = pb2.CustomDataValue(type=pb2.CustomDataType.Num, doubleValue=value) # type: ignore
45+
values[key] = pb2.CustomDataValue(
46+
type=pb2.CustomDataType.Num, doubleValue=value
47+
) # type: ignore
4248
else:
4349
logger.warning(
4450
f"Custom Data contains data type that can't be written, will be ignored. Key: {key}, Type: {str(type(value))}"

devcycle_python_sdk/protobuf/variableForUserParams_pb2.py

Lines changed: 33 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/django-app/manage.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/usr/bin/env python
22
"""Django's command-line utility for administrative tasks."""
3+
34
import os
45
import sys
56

test/test_cloud_client.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -375,9 +375,9 @@ def test_context_has_null_config_metadata(self, mock_variable_call):
375375
mock_variable_call.return_value = Variable(
376376
_id="123", key="strKey", value=999, type=TypeEnum.NUMBER
377377
)
378-
378+
379379
context_received = None
380-
380+
381381
def before_hook(context):
382382
nonlocal context_received
383383
context_received = context
@@ -398,9 +398,11 @@ def error_hook(context, error):
398398

399399
# Test that context has config_metadata field but it's null for cloud client
400400
variable = self.test_client.variable(self.test_user, "strKey", 42)
401-
401+
402+
# Verify the variable evaluation worked
403+
self.assertIsNotNone(variable)
402404
self.assertIsNotNone(context_received)
403-
self.assertTrue(hasattr(context_received, 'config_metadata'))
405+
self.assertTrue(hasattr(context_received, "config_metadata"))
404406
# Cloud client should have null config_metadata since it's not implemented
405407
self.assertIsNone(context_received.config_metadata)
406408

test/test_local_client.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,9 @@ def error_hook(context, error):
460460
@responses.activate
461461
def test_context_has_config_metadata(self):
462462
self.setup_client()
463-
463+
464464
context_received = None
465-
465+
466466
def before_hook(context):
467467
nonlocal context_received
468468
context_received = context
@@ -485,18 +485,26 @@ def error_hook(context, error):
485485

486486
# Test that context has config_metadata field
487487
variable = self.client.variable(user, "num-var", 42)
488-
488+
489+
# Verify the variable evaluation worked
490+
self.assertIsNotNone(variable)
489491
self.assertIsNotNone(context_received)
490-
self.assertTrue(hasattr(context_received, 'config_metadata'))
492+
self.assertTrue(hasattr(context_received, "config_metadata"))
491493
# For local client, config_metadata should be populated
492494
self.assertIsNotNone(context_received.config_metadata)
493-
self.assertTrue(hasattr(context_received.config_metadata, 'project'))
494-
self.assertTrue(hasattr(context_received.config_metadata, 'environment'))
495+
self.assertTrue(hasattr(context_received.config_metadata, "project"))
496+
self.assertTrue(hasattr(context_received.config_metadata, "environment"))
495497
# Verify the project and environment data
496-
self.assertEqual(context_received.config_metadata.project.id, "61f97628ff4afcb6d057dbf0")
498+
self.assertEqual(
499+
context_received.config_metadata.project.id, "61f97628ff4afcb6d057dbf0"
500+
)
497501
self.assertEqual(context_received.config_metadata.project.key, "emma-project")
498-
self.assertEqual(context_received.config_metadata.environment.id, "61f97628ff4afcb6d057dbf2")
499-
self.assertEqual(context_received.config_metadata.environment.key, "development")
502+
self.assertEqual(
503+
context_received.config_metadata.environment.id, "61f97628ff4afcb6d057dbf2"
504+
)
505+
self.assertEqual(
506+
context_received.config_metadata.environment.key, "development"
507+
)
500508

501509

502510
def _benchmark_variable_call(client: DevCycleLocalClient, user: DevCycleUser, key: str):

0 commit comments

Comments
 (0)