Describe the bug
In response to NixOS#1443, a regex check was introduced to the nix store optimise code to skip files in bla.app/Contents directories.
On my system, I also have apps with bla.app/_CodeSignature/ files that fail during hard linking, so I would suggest to extend the regex to also cover this.
Alternatively, I think nix store optimise should also just continue gracefully in cases where hardlinking fails and maybe just print a warning instead?
Steps To Reproduce
Some iOS xcarchives seem to produce this _CodeSignature directory directly in the app dir instead of Contents, although this may also be some non-standard thing. I think nix store optimise should accept it either way.
Expected behavior
nix store optimise never fails
Metadata
Additional context
Checklist
Describe the bug
In response to NixOS#1443, a regex check was introduced to the
nix store optimisecode to skip files inbla.app/Contentsdirectories.On my system, I also have apps with
bla.app/_CodeSignature/files that fail during hard linking, so I would suggest to extend the regex to also cover this.Alternatively, I think
nix store optimiseshould also just continue gracefully in cases where hardlinking fails and maybe just print a warning instead?Steps To Reproduce
Some iOS xcarchives seem to produce this
_CodeSignaturedirectory directly in the app dir instead ofContents, although this may also be some non-standard thing. I thinknix store optimiseshould accept it either way.Expected behavior
nix store optimisenever failsMetadata
Additional context
Checklist