Thanks for your fork, interested in contributing?

[nick-redwill]

Hi! First of all, thank you for your support and the work you've put into your fork, I really appreciate it.

I took a look at your changes and they’re great. While some features don’t fully align with the direction I have in mind, there are quite a few improvements that I’d love to bring into the main project.

If you're interested, I’d be happy to have you as a contributor. You’re of course free to continue maintaining your fork as well. I can even reference it for users who might prefer your approach.

Either way, thanks again for your work! It's awesome to see others building on the project! :D

[DeLuca21]

Hey, really appreciate that, glad you liked the changes.

Yeah that makes sense with the direction of the project. From your README and how things are structured, it looked like you were wanting to keep it focused on the lockscreen side, whereas my fork has drifted a bit from that.

A big reason I kept it as a fork instead of opening PRs earlier was that I ended up making some pretty large changes across a few commits, and a lot of it is fairly intertwined. I also didn’t want to spam you with a bunch of PRs without knowing what would actually fit what you’re aiming for with the main project.

I’d definitely be keen to contribute back though. If there are specific parts you liked or want to bring in, let me know what stood out and I can work out the best way to pull those pieces together, either breaking things into smaller PRs or reworking certain features cleanly against your repo.

Alternatively, I can just open a single PR with everything in it so you’ve got full visibility and can grab what you want from there, but happy to go with whatever approach you prefer.

Also keen to hear if you’ve got any ideas or features you’ve been thinking about that might fit either project.

[nick-redwill]

A big reason I kept it as a fork instead of opening PRs earlier was that I ended up making some pretty large changes across a few commits, and a lot of it is fairly intertwined. I also didn’t want to spam you with a bunch of PRs without knowing what would actually fit what you’re aiming for with the main project.

Yeah, that makes sense. Thanks for being considerate!

Right now I’m working on a few things that I plan to push to the experimental branch soon. Once that’s done I’ll let you know so you can open PRs and we can figure out what fits best into the main project.

I really like the slideshow system with folder/multiple file selection and the switch to using a JSON config for external scripts instead of plain arguments. That’s something I’d definitely like to integrate. Those are just a few highlights. I’ll take another pass and review everything more thoroughly.

Also, thanks to your code I was able to figure out a proper way to position actors on monitors without make_fullscreen. I’ll be honest, I already reused that part and made a few small improvements. I'll make sure to credit you for it!

[DeLuca21]

Yeah that all sounds good.

Happy to wait for the experimental branch, that’ll make things a lot cleaner to work from.

Good to know on the slideshow system and the JSON config as well.

A big part of why I forked it originally was wanting to support using a list of videos or a folder of videos rather than just a single file. I’ve also got a mixed multi-monitor setup with different sizes and resolutions, so I ended up improving that side of it too. It’s better now, although I’ve still got some issues on a 4K display with 150% fractional scaling.

Also nice, glad the monitor positioning helped. Keen to see what changes you made there as well, I might be able to pull some of that back into my fork.

Once you’ve pushed your changes and had a proper look through, let me know which parts you’d actually want to bring in and I’ll go through and pull together some PRs for the ones that make sense.

[nick-redwill]

It’s better now, although I’ve still got some issues on a 4K display with 150% fractional scaling.

I'm curious is that the case for my version too? Unfortunately I'm unable to test on a screen with fractional scaling.

[DeLuca21]

I haven’t tested your version with fractional scaling.

I only have LiveLockPaper installed on my work machine, and that’s where the 4K screen is.
I’m not doing any dev work there, so I haven’t really had a chance to properly test or fix it yet.

All of my testing so far has been on my home setup with 2 1080p monitors, where everything has been working mostly fine.

Also just as a heads up, I’m going to detach LiveLockPaper from the fork network.
It’s diverged quite a bit at this point and isn’t really easy to merge changes back into your project cleanly anymore, so it makes more sense for it to stand on its own.

I’ll still keep proper credit in the README for the original project, and if I contribute anything back I’ll just spin up a fresh fork and work from that.