Merge pull request OlufunbiIK#322 from fredericklamar342-prog/frederick

feat: implement on-chain version tracking and upgrade functionality

Author: OlufunbiIK

CONTRIBUTORS.md

@@ -0,0 +1,10 @@
+# Contributors
+
+Thank you to everyone who has contributed to StellarSplit! We appreciate your help in making bill splitting effortless for everyone.
+
+## Core Team
+- **OlufunbiIK** - Lead Maintainer - [GitHub](https://github.com/OlufunbiIK)
+
+## Community Contributors
+- **fredericklamar342-prog** - [GitHub](https://github.com/fredericklamar342-prog)
+- **victor-134** - [GitHub](https://github.com/victor-134)

contracts/split-escrow/src/errors.rs

@@ -16,14 +16,10 @@ pub enum Error {
     /// The maximum number of participants for this escrow has been reached.
     ParticipantCapExceeded = 10,
 
-    // Money-critical/upgrade failures are asserted by numeric code in tests.
     InvalidVersion = 11,
     InvalidInput = 12,
     EscrowNotActive = 13,
-  InvalidMetadata = 13,
-    /// Split is already finalized (released or cancelled) or otherwise not active.
     SplitNotActive = 14,
-    InvalidVersion = 15,
     InvalidMetadata = 15,
     ParticipantNotOwed = 16,
     InsufficientFulfillment = 17,

contracts/split-escrow/src/events.rs

@@ -6,13 +6,6 @@ pub fn emit_initialized(env: &Env, admin: &Address) {
     env.events().publish(("init", "admin"), admin.clone());
 }
 
-pub fn emit_contract_upgraded(env: &Env, old_version: String, new_version: String) {
-    env.events().publish(
-        ("upgraded", "old_version", "new_version"),
-        (old_version, new_version),
-    );
-}
-
 pub fn emit_split_created(env: &Env, split: &Split) {
     env.events().publish(
         ("created", "split_id", "creator"),

contracts/split-escrow/src/test.rs

@@ -109,7 +109,6 @@ fn test_admin_can_update_fee_and_treasury() {
         &false,
         &obligations_a,
         &None,
-        
     );
     client.deposit(&split_a, &participant, &1_000);
     client.release_funds(&split_a);
@@ -215,7 +214,6 @@ fn test_upgrade_version_non_admin_fails() {
 }
 
 #[test]
-#[should_panic(expected = "HostError: Error(Contract, #15)")] // InvalidVersion
 fn test_partial_deposits() {
     let (env, client, _admin, creator, participant, token_client, _) = setup();
     let p2 = Address::generate(&env);
@@ -334,7 +332,10 @@ fn test_toggle_whitelist_allows_creator_to_restrict_access() {
 fn test_create_escrow_with_metadata_stores_correctly() {
     let (env, client, _admin, creator, _participant, _token_client, _token_admin) = setup();
     let mut metadata = soroban_sdk::Map::new(&env);
-    metadata.set(String::from_str(&env, "key"), String::from_str(&env, "value"));
+    metadata.set(
+        String::from_str(&env, "key"),
+        String::from_str(&env, "value"),
+    );
 
     let split_id = client.create_escrow(
         &creator,
@@ -348,7 +349,7 @@ fn test_create_escrow_with_metadata_stores_correctly() {
     let escrow = client.get_escrow(&split_id);
     assert_eq!(escrow.metadata, metadata);
 }
-#[should_panic(expected = "HostError: Error(Contract, #15)")] // InvalidVersion
+#[should_panic(expected = "HostError: Error(Contract, #11)")] // InvalidVersion
 fn test_initialize_invalid_version_fails() {
     let env = Env::default();
     env.mock_all_auths();