Commit f625783
* Fixes #120
* Add a reference to #121
* Patch test expectation
* [Feature][DX] Add Docker Configuration for Development (#109)
* Fixes #120
* Add docker configuration for development
This makes it easier to run the test suite in your local dev environment
* Add a development section for contributors
This should make it easier for people to set up the library and run the test suite within Docker
* Added ruby service to make it easier to get started with your contribution
* Update password to match Docker configuration
* Removed outdated docker-compose file
* Use older mysql to avoid trilogy error, fix docker compose and instructions, mount code for easier development
* Update readme to point to CONTRIBUTE.md file
* Run ./bin/setup so that we have the config file in place for tests
* Relax dependency
* Add a line about the Docker + DX change
---------
Co-authored-by: Ariel Juodziukynas <arieljuod@gmail.com>
* release_connection after cleaning (#122)
For Rails >= 7.2, this library gets a connection via
`#lease_connection`. But it never releases the connection. Release the
connection back to the pool after `#clean`-ing.
Rails >= 7.2 does connection health checks / reconnect on connection
checkout. If the connection is never checked back into the pool, it will
never get "repaired", which makes testing database connection issues
tricky.
* Add a reference to #121
* Change expectation to allow for a cascade option
---------
Co-authored-by: Ariel Juodziukynas <arieljuod@gmail.com>
Co-authored-by: Andrew Lazarus <nerdrew@gmail.com>
1 parent 988ccc3 commit f625783
File tree
3 files changed
+10
-8
lines changed- lib/database_cleaner/active_record
- spec/database_cleaner/active_record
3 files changed
+10
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
| 114 | + | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
| 162 | + | |
| 163 | + | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
206 | | - | |
| 205 | + | |
| 206 | + | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
0 commit comments