No CollectionUtils.RangeToList/RangeToArray usage

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Core/Collections/CollectionUtilsTest.cs

@@ -16,6 +16,7 @@ namespace Xtensive.Orm.Tests.Core.Collections
   public class CollectionUtilsTest
   {
     [Test]
+    [Obsolete]
     public void RangeToArrayTest()
     {
       Assert.That(CollectionUtils.RangeToArray(1, 10).SequenceEqual(Enumerable.Range(1, 10)));
@@ -24,6 +25,7 @@ public void RangeToArrayTest()
     }
 
     [Test]
+    [Obsolete]
     public void RangeToListTest()
     {
       Assert.That(CollectionUtils.RangeToList(1, 10).SequenceEqual(Enumerable.Range(1, 10)));

Orm/Xtensive.Orm/Collections/CollectionUtils.cs

@@ -24,6 +24,7 @@ public static class CollectionUtils
     /// <exception cref="T:System.ArgumentOutOfRangeException">
     /// <paramref name="count"/> is less than 0.-or-
     /// <paramref name="start"/> + <paramref name="count"/> -1 is larger than <see cref="F:System.Int32.MaxValue"/>.</exception>
+    [Obsolete("Enumerable.Range().ToArray() is several times faster")]
     public static int[] RangeToArray(int start, int count)
     {
       ArgumentValidator.EnsureArgumentIsGreaterThanOrEqual(count, 0, "count");
@@ -41,6 +42,7 @@ public static int[] RangeToArray(int start, int count)
     /// <exception cref="T:System.ArgumentOutOfRangeException">
     /// <paramref name="count"/> is less than 0.-or-
     /// <paramref name="start"/> + <paramref name="count"/> -1 is larger than <see cref="F:System.Int32.MaxValue"/>.</exception>
+    [Obsolete("Enumerable.Range().ToList() is several times faster")]
     public static List<int> RangeToList(int start, int count)
     {
       ArgumentValidator.EnsureArgumentIsGreaterThanOrEqual(count, 0, "count");

Orm/Xtensive.Orm/Orm/Building/Builders/IndexBuilder.cs

@@ -805,15 +805,15 @@ private ColumnGroup BuildColumnGroup(IndexInfo index)
       var reflectedType = index.ReflectedType;
       var indexKeyColumns = index.KeyColumns;
       var keyColumns = index.IsPrimary
-        ? (IReadOnlyList<int>) CollectionUtils.RangeToArray(0, indexKeyColumns.Count)
+        ? (IReadOnlyList<int>) Enumerable.Range(0, indexKeyColumns.Count).ToArray()
         : indexKeyColumns
             .Select(static pair => pair.Key)
             .Concat(index.ValueColumns)
             .Select(static (c, i) => (c, i))
             .Where(static arg => arg.c.IsPrimaryKey)
             .Select(static arg => arg.i)
             .ToList();
-      var columns = CollectionUtils.RangeToArray(0, indexKeyColumns.Count + index.ValueColumns.Count);
+      var columns = Enumerable.Range(0, indexKeyColumns.Count + index.ValueColumns.Count).ToArray();
       return new ColumnGroup(reflectedType, keyColumns, columns);
     }
 

Orm/Xtensive.Orm/Orm/EntitySetBase.cs

@@ -940,7 +940,7 @@ private static EntitySetTypeState BuildEntitySetTypeState(FieldInfo field, Entit
             .Where(ci => ci.IsPrimaryKey)
             .Select(ci => ci.Field.MappingInfo.Offset)
             .ToList()
-        : CollectionUtils.RangeToList(0, targetDescriptor.Count);
+        : Enumerable.Range(0, targetDescriptor.Count).ToList();
 
       var keyFieldCount = ownerDescriptor.Count + itemColumnOffsets.Count;
       var keyFieldTypes = ownerDescriptor

Orm/Xtensive.Orm/Orm/Rse/Transformation/ColumnMappingInspector.cs

@@ -28,7 +28,7 @@ internal abstract class ColumnMappingInspector : CompilableProviderVisitor
 
     public virtual CompilableProvider RemoveRedundantColumns()
     {
-      mappings.Add(rootProvider, CollectionUtils.RangeToList(0, rootProvider.Header.Length));
+      mappings.Add(rootProvider, Enumerable.Range(0, rootProvider.Header.Length).ToList());
       var visitedProvider = VisitCompilable(rootProvider);
       return visitedProvider != rootProvider
         ? visitedProvider
@@ -89,25 +89,25 @@ protected override SelectProvider VisitSelect(SelectProvider provider)
     /// <inheritdoc/>
     protected override FreeTextProvider VisitFreeText(FreeTextProvider provider)
     {
-      mappings[provider] = CollectionUtils.RangeToList(0, provider.Header.Length);
+      mappings[provider] = Enumerable.Range(0, provider.Header.Length).ToList();
       return provider;
     }
 
     protected override CompilableProvider VisitContainsTable(ContainsTableProvider provider)
     {
-      mappings[provider] = CollectionUtils.RangeToList(0, provider.Header.Length);
+      mappings[provider] = Enumerable.Range(0, provider.Header.Length).ToList();
       return provider;
     }
 
     protected override IndexProvider VisitIndex(IndexProvider provider)
     {
-      mappings[provider] = CollectionUtils.RangeToList(0, provider.Header.Length);
+      mappings[provider] = Enumerable.Range(0, provider.Header.Length).ToList();
       return provider;
     }
 
     protected override SeekProvider VisitSeek(SeekProvider provider)
     {
-      mappings[provider] = CollectionUtils.RangeToList(0, provider.Header.Length);
+      mappings[provider] = Enumerable.Range(0, provider.Header.Length).ToList();
       return provider;
     }
 

Orm/Xtensive.Orm/Orm/Rse/Transformation/Internals/SkipTakeRewriter.cs

@@ -57,7 +57,7 @@ protected override CompilableProvider Visit(CompilableProvider cp)
           var headerCount = visitedProvider.Header.Length - 1;
           visitedProvider = new SelectProvider(
             visitedProvider,
-            CollectionUtils.RangeToArray(0, headerCount));
+            Enumerable.Range(0, headerCount).ToArray());
         }
 
         return visitedProvider;