Address PR 3a review: protocol gaps, transitional comment, timeout handling

Add ok/reason properties to HTTPResponseProtocol to match production usage,
widen traefik_mesh timeout handler with HTTPTimeoutError, add transitional
comment to OM V2 except clause, and add tests for ok/reason on MockHTTPResponse.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mwdd146980

datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/base.py

@@ -72,6 +72,7 @@ def check(self, _):
             with self.adopt_namespace(scraper.namespace):
                 try:
                     scraper.scrape()
+                # Pairs requests-native + library-agnostic exceptions; simplify to HTTPError after migration.
                 except (ConnectionError, RequestException, HTTPRequestError, HTTPStatusError) as e:
                     self.log.error("There was an error scraping endpoint %s: %s", endpoint, str(e))
                     raise type(e)("There was an error scraping endpoint {}: {}".format(endpoint, e)) from None

datadog_checks_base/datadog_checks/base/utils/http_protocol.py

@@ -13,6 +13,11 @@ class HTTPResponseProtocol(Protocol):
     text: str
     headers: Mapping[str, str]
 
+    @property
+    def ok(self) -> bool: ...
+    @property
+    def reason(self) -> str: ...
+
     def json(self, **kwargs: Any) -> Any: ...
     def raise_for_status(self) -> None: ...
     def close(self) -> None: ...

datadog_checks_base/tests/base/utils/http/test_http_testing.py

@@ -70,3 +70,16 @@ def test_mock_response_normalize_leading_newline():
     response = MockHTTPResponse(content=content)
 
     assert response.text == 'Actual content'
+
+
+def test_mock_response_ok_property():
+    assert MockHTTPResponse(status_code=200).ok is True
+    assert MockHTTPResponse(status_code=399).ok is True
+    assert MockHTTPResponse(status_code=400).ok is False
+    assert MockHTTPResponse(status_code=500).ok is False
+
+
+def test_mock_response_reason_property():
+    assert MockHTTPResponse(status_code=200).reason == 'OK'
+    assert MockHTTPResponse(status_code=404).reason == 'Not Found'
+    assert MockHTTPResponse(status_code=999).reason == ''

traefik_mesh/datadog_checks/traefik_mesh/check.py

@@ -10,6 +10,7 @@
 from datadog_checks.base import AgentCheck, OpenMetricsBaseCheckV2
 from datadog_checks.base.utils.http_exceptions import HTTPConnectionError as _HTTPConnectionError
 from datadog_checks.base.utils.http_exceptions import HTTPStatusError
+from datadog_checks.base.utils.http_exceptions import HTTPTimeoutError as _HTTPTimeoutError
 from datadog_checks.traefik_mesh.config_models import ConfigMixin
 from datadog_checks.traefik_mesh.metrics import METRIC_MAP, RENAME_LABELS
 
@@ -123,6 +124,6 @@ def _get_json(self, url):
             self.warning(
                 "Couldn't connect to URL: %s with exception: %s. Please verify the address is reachable", url, e
             )
-        except requests.exceptions.Timeout as e:
+        except (requests.exceptions.Timeout, _HTTPTimeoutError) as e:
             self.warning("Connection timeout when connecting to %s: %s", url, e)
         return None