Continue cursor pagination until results are empty (#3474)

* Continue cursor pagination until results are empty

Mirror DataDog/datadog-api-client-go#3769: when an endpoint uses cursor-based pagination, keep requesting pages until the server returns an empty result set instead of stopping at the first page smaller than the requested limit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Also stop cursor pagination when next cursor is missing

If the response omits the next-cursor field (or returns it empty/null), there is no way to fetch a further page, so the loop should terminate even when the current page still has results.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: nogates

.generator/src/generator/templates/api_client.j2

@@ -350,9 +350,13 @@ class ApiClient:
                 host=host,
                 collection_formats=params["collection_format"],
             )
-            for item in get_attribute_from_path(response, pagination.get("results_path")):
+            results = get_attribute_from_path(response, pagination.get("results_path"))
+            for item in results:
                 yield item
-            if len(get_attribute_from_path(response, pagination.get("results_path"))) < pagination["limit_value"]:
+            if "cursor_param" in pagination:
+                if len(results) == 0 or not get_attribute_from_path(response, pagination["cursor_path"], default=""):
+                    break
+            elif len(results) < pagination["limit_value"]:
                 break
 
             params = self._update_paginated_params(pagination, response)
@@ -651,9 +655,13 @@ class AsyncApiClient(ApiClient):
                 host=host,
                 collection_formats=params["collection_format"],
             )
-            for item in get_attribute_from_path(response, pagination.get("results_path")):
+            results = get_attribute_from_path(response, pagination.get("results_path"))
+            for item in results:
                 yield item
-            if len(get_attribute_from_path(response, pagination.get("results_path"))) < pagination["limit_value"]:
+            if "cursor_param" in pagination:
+                if len(results) == 0 or not get_attribute_from_path(response, pagination["cursor_path"], default=""):
+                    break
+            elif len(results) < pagination["limit_value"]:
                 break
 
             params = self._update_paginated_params(pagination, response)

src/datadog_api_client/api_client.py

@@ -357,9 +357,13 @@ def call_api_paginated(
                 host=host,
                 collection_formats=params["collection_format"],
             )
-            for item in get_attribute_from_path(response, pagination.get("results_path")):
+            results = get_attribute_from_path(response, pagination.get("results_path"))
+            for item in results:
                 yield item
-            if len(get_attribute_from_path(response, pagination.get("results_path"))) < pagination["limit_value"]:
+            if "cursor_param" in pagination:
+                if len(results) == 0 or not get_attribute_from_path(response, pagination["cursor_path"], default=""):
+                    break
+            elif len(results) < pagination["limit_value"]:
                 break
 
             params = self._update_paginated_params(pagination, response)
@@ -659,9 +663,13 @@ async def call_api_paginated(
                 host=host,
                 collection_formats=params["collection_format"],
             )
-            for item in get_attribute_from_path(response, pagination.get("results_path")):
+            results = get_attribute_from_path(response, pagination.get("results_path"))
+            for item in results:
                 yield item
-            if len(get_attribute_from_path(response, pagination.get("results_path"))) < pagination["limit_value"]:
+            if "cursor_param" in pagination:
+                if len(results) == 0 or not get_attribute_from_path(response, pagination["cursor_path"], default=""):
+                    break
+            elif len(results) < pagination["limit_value"]:
                 break
 
             params = self._update_paginated_params(pagination, response)