Skip to content

Fix race condition in the telemetry daemon payload processing logic#277

Merged
ofek merged 1 commit into
mainfrom
ofek/telemetry
May 14, 2026
Merged

Fix race condition in the telemetry daemon payload processing logic#277
ofek merged 1 commit into
mainfrom
ofek/telemetry

Conversation

@ofek
Copy link
Copy Markdown
Contributor

@ofek ofek commented May 14, 2026

#274 changed the name of temporary files used for atomic writes so the filter to ignore them no longer worked:

2026-05-14 01:45:50,255 | ERROR | Failed to set up client: .trace
Traceback (most recent call last):
  File "C:\Users\ofek\Desktop\code\datadog-agent-dev\src\dda\telemetry\daemon\__main__.py", line 89, in process_changes
    client = get_client(client_id, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\ofek\Desktop\code\datadog-agent-dev\src\dda\telemetry\daemon\__main__.py", line 45, in get_client
    raise ValueError(message)
ValueError: Unknown client ID: .trace

The watcher should never have had knowledge of naming schemes however so now what gets watched is explicit.

The change in the name of temporary files is unnecessary but after thinking about it this is better.

@ofek ofek requested a review from a team as a code owner May 14, 2026 07:06
@ofek ofek merged commit 1f421ea into main May 14, 2026
25 checks passed
@ofek ofek deleted the ofek/telemetry branch May 14, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant