Confirm processStatus classification for KYC dfxApproval step (InProgress vs PendingReview)

[joshuakrueger-dfx]

Context

In the app (DFXswiss/realunit-app), an in-progress dfxApproval KYC step was rendering a blank white screen. PR #618 (realunit-app#618) is the defensive client-side fix — it renders the existing pending page instead of the silent Scaffold() fallback, and hardens the KycStep switch to be exhaustive.

That fix is correct at the render layer, but it surfaced an API-side classification question worth confirming here.

Question

After Wave 2.2 routing (realunit-app PR #494), the app derives its KYC view purely from processStatus:

• PendingReview → KycPending(stepUnderReview) — already covers InternalReview / ManualReview / etc. per KycInfoMapper.computeProcessStatus
• InProgress → KycSuccess(currentStep) — intended for user-actionable steps

dfxApproval is currently reaching the client as KycSuccess(currentStep: dfxApproval), i.e. classified as InProgress.

If dfxApproval is a backend-side wait with no user action required, it semantically belongs under PendingReview (→ KycPending), not InProgress. In that case the client would route it correctly without relying on the defensive fallback.

Ask

Please confirm whether the processStatus mapping for dfxApproval is intentional:

1. If dfxApproval requires user action → keeping it InProgress is correct; the app fix stands as-is.
2. If dfxApproval is a backend wait → consider mapping it to PendingReview so it routes through the existing pending/under-review path by status, consistent with the other review states.

No app change is blocked on this — realunit-app#618 already prevents the blank screen for users on develop. This is purely to confirm the source-of-truth classification.

Filed as a follow-up to a review on realunit-app#618.

[joshuakrueger-dfx]

Implemented in #3794 — with concrete root cause: KycStep.create() defaults to IN_PROGRESS, so a DfxApproval step in an actionable status made KycInfoMapper compute processStatus=InProgress and pick it as currentStep. #3794 classifies DfxApproval (a DFX-side decision) as non-user-actionable → PendingReview, never currentStep. Red→green mapper specs included.