Skip to content

Commit decb77e

Browse files
committed
Re-enable shadow renames, except for com.oracle.truffle, Closes #32
This makes this mod work correctle on all JVMs, including GraalVM 21 and 23.
1 parent 8b88ba0 commit decb77e

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

build.gradle

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ dependencies {
148148
modLib ("org.graalvm.js:js:${project.graal_version}") {
149149
exclude group: 'com.ibm.icu', module: 'icu4j'
150150
}
151-
shadow "org.graalvm.js:js:${project.graal_version}" // TODO: not working anymore after shadow... Don't rename during shadow?...
151+
shadow "org.graalvm.js:js:${project.graal_version}"
152152

153153

154154
// Project lombok
@@ -262,9 +262,13 @@ shadowJar {
262262
configurations = [project.configurations.shadow]
263263
archiveClassifier.set(''); // Replace the default JAR
264264
// To avoid clashes with other mods
265-
// relocate 'org.graalvm', 'org.cyclops.integratedscripting.vendors.org.graalvm'
266-
// relocate 'com.oracle', 'org.cyclops.integratedscripting.vendors.com.oracle'
265+
relocate 'org.graalvm', 'org.cyclops.integratedscripting.vendors.org.graalvm'
267266
relocate 'com.ibm', 'org.cyclops.integratedscripting.vendors.com.ibm'
267+
// Relocate everything from com.oracle, except for com.oracle.truffle, as this is defined in a native lib, which can not be relocated
268+
// relocate 'com.oracle', 'org.cyclops.integratedscripting.vendors.com.oracle'
269+
relocate 'com.oracle.js', 'org.cyclops.integratedscripting.vendors.com.oracle.js'
270+
relocate 'com.oracle.svm', 'org.cyclops.integratedscripting.vendors.com.oracle.svm'
271+
// relocate 'com.oracle.truffle', 'org.cyclops.integratedscripting.vendors.com.oracle.truffle' // Relocation of this fails for com.oracle.truffle.runtime.ModulesSupport at runtime
268272
}
269273
assemble.dependsOn shadowJar
270274
jar {

0 commit comments

Comments
 (0)