Skip to content

feedback #13

@mdipierro

Description

@mdipierro
  • no need to pass action.uses(..., url_signer) since not used
  • good use of placeholders
  • this is correct db.course.name.like(f'%{keyword}%') but you could have done db.course.name.contains(keyword)
  • the me api may expose user's encrypted password which may be cached by the browser (minor vulnerability)

Contribution stats (by author) on the current branch:

     Colby <csfrey@ucsc.edu>:
      insertions:    44029  (28%)
      deletions:     43395  (48%)
      files:         320    (21%)
      commits:       35     (28%)
      lines changed: 87424  (36%)
      first commit:  Sat Jun 3 18:22:26 2023 -0700
      last commit:   Fri Jun 9 23:45:40 2023 -0700

     drunkNH <jgu6661@gmail.com>:
      insertions:    884    (1%)
      deletions:     455    (0%)
      files:         58     (4%)
      commits:       25     (20%)
      lines changed: 1339   (1%)
      first commit:  Mon May 29 15:39:09 2023 -0700
      last commit:   Fri Jun 9 22:42:57 2023 -0700

     PureYou <57725751+drunkNH@users.noreply.github.com>:
      insertions:    7      (0%)
      deletions:     7      (0%)
      files:         1      (0%)
      commits:       1      (1%)
      lines changed: 14     (0%)
      first commit:  Tue May 30 17:15:16 2023 -0700
      last commit:   Tue May 30 17:15:16 2023 -0700

     Jasmin Perez <jpere131@ucsc.edu>:
      insertions:    46985  (30%)
      deletions:     4434   (5%)
      files:         906    (59%)
      commits:       20     (16%)
      lines changed: 51419  (21%)
      first commit:  Tue May 30 19:50:59 2023 -0700
      last commit:   Fri Jun 9 23:15:18 2023 -0700

     Neeha Ravula <ravulaneeha@gmail.com>:
      insertions:    1057   (1%)
      deletions:     731    (1%)
      files:         43     (3%)
      commits:       23     (19%)
      lines changed: 1788   (1%)
      first commit:  Wed May 31 18:11:37 2023 -0700
      last commit:   Fri Jun 9 22:22:02 2023 -0700

     Colby Frey <csfrey@ucsc.edu>:
      insertions:    61315  (40%)
      deletions:     41     (0%)
      files:         75     (5%)
      commits:       3      (2%)
      lines changed: 61356  (25%)
      first commit:  Sat May 27 23:56:15 2023 -0700
      last commit:   Thu Jun 1 12:32:10 2023 -0700

     Vincent Jay Olandria <volandri@ucsc.edu>:
      insertions:    358    (0%)
      deletions:     130    (0%)
      files:         16     (1%)
      commits:       5      (4%)
      lines changed: 488    (0%)
      first commit:  Tue May 30 14:22:48 2023 -0700
      last commit:   Fri Jun 9 21:45:46 2023 -0700

     Neeha Ravula <54718232+neeharavula@users.noreply.github.com>:
      insertions:    106    (0%)
      deletions:     42071  (46%)
      files:         124    (8%)
      commits:       11     (9%)
      lines changed: 42177  (17%)
      first commit:  Mon May 8 20:36:04 2023 -0700
      last commit:   Fri Jun 9 21:41:03 2023 -0700

    total:
      insertions:    154741 (100%)
      deletions:     91264  (100%)
      files:         1543   (100%)
      commits:       123    (100%)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions