Skip to content

Commit 8338be3

Browse files
Elaine WangElaine Wang
authored andcommitted
fix: respect CORTEX_HOME in feedback
1 parent 7954d02 commit 8338be3

1 file changed

Lines changed: 22 additions & 3 deletions

File tree

src/cortex-cli/src/feedback_cmd.rs

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,13 @@ struct FeedbackEntry {
121121

122122
/// Get the feedback directory.
123123
fn get_feedback_dir() -> PathBuf {
124-
dirs::home_dir()
125-
.map(|h| h.join(".cortex").join("feedback"))
126-
.unwrap_or_else(|| PathBuf::from(".cortex/feedback"))
124+
cortex_common::get_cortex_home()
125+
.unwrap_or_else(|| {
126+
dirs::home_dir()
127+
.map(|h| h.join(".cortex"))
128+
.unwrap_or_else(|| PathBuf::from(".cortex"))
129+
})
130+
.join("feedback")
127131
}
128132

129133
impl FeedbackCli {
@@ -411,6 +415,21 @@ fn read_single_line() -> Result<String> {
411415
mod tests {
412416
use super::*;
413417

418+
#[test]
419+
fn test_get_feedback_dir_respects_cortex_home() {
420+
let previous = std::env::var_os("CORTEX_HOME");
421+
let expected_home = std::env::temp_dir().join("cortex-feedback-test-home");
422+
423+
unsafe { std::env::set_var("CORTEX_HOME", &expected_home) };
424+
assert_eq!(get_feedback_dir(), expected_home.join("feedback"));
425+
426+
if let Some(value) = previous {
427+
unsafe { std::env::set_var("CORTEX_HOME", value) };
428+
} else {
429+
unsafe { std::env::remove_var("CORTEX_HOME") };
430+
}
431+
}
432+
414433
#[test]
415434
fn test_feedback_entry_serialization_with_session() {
416435
let entry = FeedbackEntry {

0 commit comments

Comments
 (0)