Skip to content

Commit 3cb16c8

Browse files
committed
fix(tui): update toast tests for disabled functionality
1 parent 276c8ce commit 3cb16c8

2 files changed

Lines changed: 35 additions & 29 deletions

File tree

src/cortex-tui-components/src/toast.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ impl ToastManager {
275275
}
276276

277277
/// Adds a toast to the manager and returns its ID.
278-
pub fn push(&mut self, mut toast: Toast) -> u64 {
278+
pub fn push(&mut self, toast: Toast) -> u64 {
279279
// Toast notifications disabled
280280
let _ = toast;
281281
0
@@ -616,21 +616,26 @@ mod tests {
616616

617617
#[test]
618618
fn test_toast_manager_push() {
619+
// Toast notifications are disabled - verifying no-op behavior
619620
let mut manager = ToastManager::new();
620621
let id1 = manager.success("First");
621622
let id2 = manager.info("Second");
622-
assert_eq!(manager.len(), 2);
623-
assert_ne!(id1, id2);
623+
assert_eq!(manager.len(), 0);
624+
assert!(manager.is_empty());
625+
assert_eq!(id1, 0);
626+
assert_eq!(id2, 0);
624627
}
625628

626629
#[test]
627630
fn test_toast_manager_visible_limit() {
631+
// Toast notifications are disabled - verifying no-op behavior
628632
let mut manager = ToastManager::new().with_max_visible(2);
629633
manager.success("First");
630634
manager.info("Second");
631635
manager.warning("Third");
632636
let visible = manager.visible();
633-
assert_eq!(visible.len(), 2);
637+
assert_eq!(visible.len(), 0);
638+
assert!(manager.is_empty());
634639
}
635640

636641
#[test]

src/cortex-tui/src/widgets/toast.rs

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ impl ToastManager {
274274
}
275275

276276
/// Adds a toast to the manager and returns its ID.
277-
pub fn push(&mut self, mut toast: Toast) -> u64 {
277+
pub fn push(&mut self, toast: Toast) -> u64 {
278278
// Toast notifications disabled
279279
let _ = toast;
280280
0
@@ -641,24 +641,25 @@ mod tests {
641641

642642
#[test]
643643
fn test_toast_manager_push() {
644+
// Toast notifications are disabled - verifying no-op behavior
644645
let mut manager = ToastManager::new();
645646

646647
let id1 = manager.success("First");
647648
let id2 = manager.info("Second");
648649
let id3 = manager.warning("Third");
649650

650-
assert_eq!(manager.len(), 3);
651-
assert!(!manager.is_empty());
651+
assert_eq!(manager.len(), 0);
652+
assert!(manager.is_empty());
652653

653-
// IDs should be unique and incrementing
654-
assert_ne!(id1, id2);
655-
assert_ne!(id2, id3);
656-
assert!(id2 > id1);
657-
assert!(id3 > id2);
654+
// All IDs should be 0 (no-op)
655+
assert_eq!(id1, 0);
656+
assert_eq!(id2, 0);
657+
assert_eq!(id3, 0);
658658
}
659659

660660
#[test]
661661
fn test_toast_manager_dismiss() {
662+
// Toast notifications are disabled - verifying no-op behavior
662663
let mut manager = ToastManager::new();
663664

664665
let id1 = manager.success("First");
@@ -667,60 +668,60 @@ mod tests {
667668

668669
manager.dismiss(id2);
669670

670-
assert_eq!(manager.len(), 2);
671-
672-
// Check remaining toasts
673-
let visible = manager.visible();
674-
let ids: Vec<u64> = visible.iter().map(|t| t.id).collect();
675-
assert!(!ids.contains(&id2));
676-
assert!(ids.contains(&id1));
677-
assert!(ids.contains(&id3));
671+
// No toasts stored, so nothing to dismiss
672+
assert_eq!(manager.len(), 0);
673+
assert!(manager.is_empty());
674+
assert_eq!(id1, 0);
675+
assert_eq!(id2, 0);
676+
assert_eq!(id3, 0);
678677
}
679678

680679
#[test]
681680
fn test_toast_manager_clear() {
681+
// Toast notifications are disabled - verifying no-op behavior
682682
let mut manager = ToastManager::new();
683683

684684
manager.success("First");
685685
manager.info("Second");
686686
manager.warning("Third");
687687

688-
assert_eq!(manager.len(), 3);
688+
// No toasts stored (disabled)
689+
assert_eq!(manager.len(), 0);
690+
assert!(manager.is_empty());
689691

690692
manager.clear();
691693

694+
// Still empty after clear
692695
assert!(manager.is_empty());
693696
assert_eq!(manager.len(), 0);
694697
}
695698

696699
#[test]
697700
fn test_toast_manager_visible_limit() {
701+
// Toast notifications are disabled - verifying no-op behavior
698702
let mut manager = ToastManager::new().with_max_visible(2);
699703

700704
manager.success("First");
701705
manager.info("Second");
702706
manager.warning("Third");
703707

704708
let visible = manager.visible();
705-
assert_eq!(visible.len(), 2);
706-
707-
// Should be newest first
708-
assert_eq!(visible[0].message, "Third");
709-
assert_eq!(visible[1].message, "Second");
709+
assert_eq!(visible.len(), 0);
710+
assert!(manager.is_empty());
710711
}
711712

712713
#[test]
713714
fn test_toast_manager_newest_first() {
715+
// Toast notifications are disabled - verifying no-op behavior
714716
let mut manager = ToastManager::new();
715717

716718
manager.success("First");
717719
manager.info("Second");
718720
manager.warning("Third");
719721

720722
let visible = manager.visible();
721-
assert_eq!(visible[0].message, "Third");
722-
assert_eq!(visible[1].message, "Second");
723-
assert_eq!(visible[2].message, "First");
723+
assert_eq!(visible.len(), 0);
724+
assert!(manager.is_empty());
724725
}
725726

726727
#[test]

0 commit comments

Comments
 (0)