Skip to content

Commit bbbaebc

Browse files
committed
Unlimited timeout
1 parent c4eeb16 commit bbbaebc

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/main/java/com/convertapi/client/Config.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
public class Config {
88
private static String defaultSecret;
9-
private static int defaultTimeout = 180;
9+
private static int defaultTimeout = 0; // Infinite read waiting
1010
private static Function<OkHttpClient.Builder, OkHttpClient.Builder> defaultHttpClientBuilder = b -> b;
1111
private static final String SCHEME = "https";
1212
@SuppressWarnings("SpellCheckingInspection")

src/main/java/com/convertapi/client/ConvertApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
@SuppressWarnings("WeakerAccess")
2323
public class ConvertApi {
2424
@SuppressWarnings("SpellCheckingInspection")
25-
private static final List<String> IGNORE_PARAMS = Arrays.asList("storefile", "async", "jobid", "timeout");
25+
private static final List<String> IGNORE_PARAMS = Arrays.asList("storefile", "async", "jobid");
2626

2727
@SuppressWarnings("unused")
2828
public static CompletableFuture<ConversionResult> convert(String fromFormat, String toFormat, Param... params) {

src/main/java/com/convertapi/client/Http.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ static OkHttpClient getClient() {
1717
}
1818

1919
static OkHttpClient getClient(Config config) {
20+
int timeout = config.getTimeout() > 0 ? config.getTimeout() + 5 : 0;
2021
return config.getHttpClientBuilder()
2122
.apply(getClient().newBuilder())
22-
.readTimeout(config.getTimeout() + 5, TimeUnit.SECONDS)
23+
.readTimeout(timeout, TimeUnit.SECONDS)
2324
.build();
2425
}
2526

0 commit comments

Comments
 (0)