Show error if user use storeFile parameter

Author: paulius-petkus

ConvertApi.Cli.Tests/CliTests.cs

@@ -41,6 +41,18 @@ public void TestMergePdfs()
         Assert.AreEqual(0, process.ExitCode, "CLI did not exit cleanly.");
         Assert.IsTrue(File.Exists(outputFile), "Output file was not created.");
     }
+    
+    [Test]
+    public void TestCompareDocx()
+    {
+        var outputFile = Path.Combine(TestOutputDir, "demo.docx");
+        var inputFile1 = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "demo.docx");
+        var inputFile2 = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "demo-changed.docx");
+        var process = RunCli($"{ApiToken} {outputFile} {inputFile1} docx compare CompareFile={inputFile2} storeFile=true");
+
+        Assert.AreEqual(0, process.ExitCode, "CLI did not exit cleanly.");
+        Assert.IsTrue(!File.Exists(outputFile), "Output file should not be not created.");
+    }
 
     [Test]
     public void TestAddWatermarkToPdf()

ConvertApi.Cli.Tests/DirectCallTests.cs

@@ -70,9 +70,21 @@ public async Task TestAddWatermarkOverlayToPdf()
     {
         var outputFile = Path.Combine(TestOutputDir, "watermarkOverlay.pdf");
         var inputFile = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "simple.pdf");
-        var overlayFile = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "simple.pdf");
+        var overlayFile = @"D:\Code\ConvertApi\ConvertApi.Converter.PdfToolkit\ConvertApi.Converter.PdfToolkit.Tests\Files\Watermark\green.pdf";
 
-        await Program.Main([ApiToken, TestOutputDir, inputFile, "pdf", "watermark-overlay", "FileName=watermarkOverlay", $"OverlayFile={overlayFile}"]);
+        await Program.Main([ApiToken, TestOutputDir, inputFile, "pdf", "watermark-overlay", $"OverlayFile={overlayFile}"]);
+    
+        Assert.IsTrue(File.Exists(outputFile), "Output file was not created.");
+    }
+    
+    [Test]
+    public async Task TestDocxCompare()
+    {
+        var outputFile = Path.Combine(TestOutputDir, "demo.docx");
+        var inputFile = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "demo.docx");
+        var compareFile = Path.Combine(Directory.GetCurrentDirectory(), "../../../../", "test_files", "demo-changed.docx");
+    
+        await Program.Main([ApiToken, TestOutputDir, inputFile, "docx", "compare", $"CompareFile={compareFile}", "storeFile=false"]);
 
         Assert.IsTrue(File.Exists(outputFile), "Output file was not created.");
     }

ConvertApi.Cli/Program.cs

@@ -1,4 +1,4 @@
-using System.Diagnostics;
+using System.Diagnostics;
 using System.Net.Http.Headers;
 using System.Reflection;
 using Microsoft.AspNetCore.WebUtilities;
@@ -48,6 +48,12 @@ public static async Task Main(string[] args)
             arg => arg.Split('=')[1]
         );
 
+        if (dynamicProperties.Any(x => x.Key.ToLower() == "storefile" && x.Value.ToLower() == "true"))
+        {
+            Console.WriteLine("Error: StoreFile parameter is now allowed in cli tool. Please use our API directly if you need this parameter.");
+            return;
+        }
+
         // Setting file name for simplified (3 parameters) conversion.
         if (args.Length == 3 && dynamicProperties.Keys.All(x => !x.Equals("FileName", StringComparison.CurrentCultureIgnoreCase)))
             dynamicProperties.Add("FileName", Path.GetFileNameWithoutExtension(outputDirectoryOrFile));
@@ -132,8 +138,8 @@ static async Task ConvertFiles(string apiToken, string fromFormat, string toForm
                     }
                 }
             }
-
-            foreach (var (filePropertyName, filePath) in properties.Where(x => x.Key.ToLower().EndsWith("file")))
+            
+            foreach (var (filePropertyName, filePath) in properties.Where(x => x.Key.ToLower().EndsWith("file") && x.Key.ToLower() != ("storefile")))
             {
                 AddFilesToFormParameters(form, filePropertyName, filePath);
             }