fix copilot review issues: add init files, fix function signatures, add comments to except clauses, improve edge counting

Author: Sahil-u07

concore_cli/commands/inspect.py

@@ -6,15 +6,15 @@
 from collections import defaultdict
 import re
 
-def inspect_workflow(workflow_file, console, output_json=False):
+def inspect_workflow(workflow_file, source_dir, output_json, console):
     workflow_path = Path(workflow_file)
 
     if output_json:
-        return _inspect_json(workflow_path)
+        return _inspect_json(workflow_path, source_dir)
 
-    _inspect_rich(workflow_path, console)
+    _inspect_rich(workflow_path, source_dir, console)
 
-def _inspect_rich(workflow_path, console):
+def _inspect_rich(workflow_path, source_dir, console):
     console.print()
     console.print(f"[bold cyan]Workflow:[/bold cyan] {workflow_path.name}")
     console.print()
@@ -60,7 +60,7 @@ def _inspect_rich(workflow_path, console):
                     else:
                         lang_counts['Other'] += 1
 
-                    src_dir = workflow_path.parent / 'src'
+                    src_dir = workflow_path.parent / source_dir
                     if not (src_dir / filename).exists():
                         missing_files.append(filename)
 
@@ -77,11 +77,11 @@ def _inspect_rich(workflow_path, console):
 
         for edge in edges:
             label_tag = edge.find('y:EdgeLabel')
-            if label_tag and label_tag.text:
-                if edge_label_regex.match(label_tag.text.strip()):
-                    zmq_count += 1
-                else:
-                    file_count += 1
+            label_text = label_tag.text.strip() if label_tag and label_tag.text else ""
+            if label_text and edge_label_regex.match(label_text):
+                zmq_count += 1
+            else:
+                file_count += 1
 
         if zmq_count > 0:
             edges_branch.add(f"ZMQ: {zmq_count}")
@@ -126,7 +126,7 @@ def _inspect_rich(workflow_path, console):
                         }
                         lang = lang_map.get(ext, 'Other')
 
-                        src_dir = workflow_path.parent / 'src'
+                        src_dir = workflow_path.parent / source_dir
                         status = "✓" if (src_dir / filename).exists() else "✗"
 
                         table.add_row(node_id, filename, lang, status)
@@ -166,7 +166,7 @@ def _inspect_rich(workflow_path, console):
     except Exception as e:
         console.print(f"[red]Inspection failed:[/red] {str(e)}")
 
-def _inspect_json(workflow_path):
+def _inspect_json(workflow_path, source_dir):
     import json
 
     try:
@@ -175,6 +175,10 @@ def _inspect_json(workflow_path):
 
         soup = BeautifulSoup(content, 'xml')
 
+        if not soup.find('graphml'):
+            print(json.dumps({'error': 'Not a valid GraphML file'}, indent=2))
+            return
+        
         nodes = soup.find_all('node')
         edges = soup.find_all('edge')
 
@@ -202,7 +206,7 @@ def _inspect_json(workflow_path):
                     lang = lang_map.get(ext, 'other')
                     lang_counts[lang] += 1
 
-                    src_dir = workflow_path.parent / 'src'
+                    src_dir = workflow_path.parent / source_dir
                     exists = (src_dir / filename).exists()
                     if not exists:
                         missing_files.append(filename)
@@ -223,13 +227,13 @@ def _inspect_json(workflow_path):
             target = edge.get('target')
 
             label_tag = edge.find('y:EdgeLabel')
+            label_text = label_tag.text.strip() if label_tag and label_tag.text else ""
             edge_type = 'file'
-            if label_tag and label_tag.text:
-                if edge_label_regex.match(label_tag.text.strip()):
-                    edge_type = 'zmq'
-                    zmq_count += 1
-                else:
-                    file_count += 1
+            if label_text and edge_label_regex.match(label_text):
+                edge_type = 'zmq'
+                zmq_count += 1
+            else:
+                file_count += 1
 
             edge_list.append({
                 'source': source,

concore_cli/commands/status.py

@@ -38,12 +38,14 @@ def show_status(console):
                         minutes, seconds = divmod(remainder, 60)
                         uptime_str = f"{hours}h {minutes}m {seconds}s"
                     except:
+                        # Failed to calculate uptime
                         uptime_str = "unknown"
 
                     try:
                         mem_mb = proc.info['memory_info'].rss / 1024 / 1024
                         mem_str = f"{mem_mb:.1f} MB"
                     except:
+                        # Failed to get memory info
                         mem_str = "unknown"
 
                     command = ' '.join(cmdline[:3]) if len(cmdline) >= 3 else cmdline_str[:50]

concore_cli/commands/stop.py

@@ -31,7 +31,7 @@ def stop_all(console):
                 if is_concore:
                     processes_to_kill.append(proc)
             except (psutil.NoSuchProcess, psutil.AccessDenied):
-                # Process may have exited or be inaccessible; safe to ignore
+                # Process already exited or access denied; continue
                 continue
 
     except Exception as e:

pyproject.toml

@@ -28,3 +28,4 @@ concore = "concore_cli.cli:cli"
 
 [tool.setuptools]
 packages = ["concore_cli", "concore_cli.commands"]
+py-modules = ["mkconcore"]