Skip to content

Commit 5e9308e

Browse files
committed
don't overload the setter
1 parent 34b15dc commit 5e9308e

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

constructorio-client/src/main/java/io/constructor/client/CatalogRequest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ public String getSection() {
8686

8787
/**
8888
* @param email the email address to receive a notification in case the task fails
89+
* @deprecated Use {@link #setNotificationEmails(List)} instead to support multiple emails.
8990
*/
91+
@Deprecated
9092
public void setNotificationEmail(String email) {
9193
this.notificationEmails.clear();
9294
if (email != null) {
@@ -98,7 +100,7 @@ public void setNotificationEmail(String email) {
98100
* @param emails list of email addresses where you'd like to receive notifications in case the
99101
* task fails
100102
*/
101-
public void setNotificationEmail(List<String> emails) {
103+
public void setNotificationEmails(List<String> emails) {
102104
this.notificationEmails.clear();
103105
if (emails != null) {
104106
this.notificationEmails.addAll(emails);

constructorio-client/src/test/java/io/constructor/client/CatalogRequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void setNotificationEmailShouldSet() throws Exception {
8686
CatalogRequest request = new CatalogRequest(files, "Products");
8787

8888
List<String> emails = Arrays.asList("a@constructor.io", "b@constructor.io");
89-
request.setNotificationEmail(emails);
89+
request.setNotificationEmails(emails);
9090

9191
assertEquals(request.getNotificationEmails(), emails);
9292
assertEquals(request.getNotificationEmail(), "a@constructor.io");

constructorio-client/src/test/java/io/constructor/client/ConstructorIONotificationEmailTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ public void replaceCatalogWithMultipleEmailsShouldIncludeAllEmailsInUrl() throws
296296
Map<String, File> files = new HashMap<String, File>();
297297
files.put("items", new File("src/test/resources/items.csv"));
298298
CatalogRequest req = new CatalogRequest(files, "Products");
299-
req.setNotificationEmail(Arrays.asList("a@constructor.io", "b@constructor.io"));
299+
req.setNotificationEmails(Arrays.asList("a@constructor.io", "b@constructor.io"));
300300

301301
constructor.replaceCatalog(req);
302302

@@ -342,7 +342,7 @@ public void updateCatalogWithMultipleEmailsShouldIncludeAllEmailsInUrl() throws
342342
Map<String, File> files = new HashMap<String, File>();
343343
files.put("items", new File("src/test/resources/items.csv"));
344344
CatalogRequest req = new CatalogRequest(files, "Products");
345-
req.setNotificationEmail(Arrays.asList("a@constructor.io", "b@constructor.io"));
345+
req.setNotificationEmails(Arrays.asList("a@constructor.io", "b@constructor.io"));
346346

347347
constructor.updateCatalog(req);
348348

@@ -369,7 +369,7 @@ public void patchCatalogWithMultipleEmailsShouldIncludeAllEmailsInUrl() throws E
369369
Map<String, File> files = new HashMap<String, File>();
370370
files.put("items", new File("src/test/resources/items.csv"));
371371
CatalogRequest req = new CatalogRequest(files, "Products");
372-
req.setNotificationEmail(Arrays.asList("a@constructor.io", "b@constructor.io"));
372+
req.setNotificationEmails(Arrays.asList("a@constructor.io", "b@constructor.io"));
373373

374374
constructor.patchCatalog(req);
375375

0 commit comments

Comments
 (0)