fix: animation shimmering issue

Author: at-wr

Outspire.swiftpm/Core/Services/AnimationManager.swift

@@ -1,4 +1,5 @@
 import Foundation
+import SwiftUI
 
 class AnimationManager {
     static let shared = AnimationManager()
@@ -8,12 +9,44 @@ class AnimationManager {
     // Tracking app launch state
     private(set) var isFirstLaunch = true
 
+    // Dictionary to track animation states for different views
+    private var animatedViews: [String: Bool] = [:]
+    
     func markAppLaunched() {
         isFirstLaunch = false
     }
 
     func resetAnimationFlags() {
         // Reset for testing or when signing out
         isFirstLaunch = true
+        animatedViews.removeAll()
+    }
+    
+    // Track if a specific view has been animated
+    func hasAnimated(viewId: String) -> Bool {
+        return animatedViews[viewId] ?? false
+    }
+    
+    // Mark a specific view as animated
+    func markAnimated(viewId: String) {
+        animatedViews[viewId] = true
+    }
+    
+    // Force a view to animate again
+    func resetAnimation(viewId: String) {
+        animatedViews[viewId] = false
+    }
+}
+
+// Extension to help determine device characteristics
+extension UIDevice {
+    static var isSmallScreen: Bool {
+        let screenSize = UIScreen.main.bounds.size
+        let smallerDimension = min(screenSize.width, screenSize.height)
+        return smallerDimension <= 375 // iPhone SE, iPhone 8 and similar
+    }
+    
+    static var isIpad: Bool {
+        return UIDevice.current.userInterfaceIdiom == .pad
     }
 }

Outspire.swiftpm/Features/CAS/Views/ClubActivitiesView.swift

@@ -234,7 +234,7 @@ struct ActivitiesSection: View {
                     .transition(.opacity)
                     .animation(.easeInOut(duration: 0.5), value: viewModel.isLoadingActivities)
             } else if viewModel.activities.isEmpty {
-                EmptyStateView(action: { showingAddRecordSheet.toggle() })
+                ClubEmptyStateView(action: { showingAddRecordSheet.toggle() })
                     .transition(.scale.combined(with: .opacity))
             } else {
                 ActivitiesList(viewModel: viewModel, animateList: animateList)
@@ -290,7 +290,7 @@ struct AddButton: View {
     }
 }
 
-struct EmptyStateView: View {
+struct ClubEmptyStateView: View {
     let action: () -> Void
 
     var body: some View {

Outspire.swiftpm/Features/SchoolArrangement/ViewModels/SchoolArrangementViewModel.swift

@@ -15,6 +15,10 @@ class SchoolArrangementViewModel: ObservableObject {
     @Published var isLoadingDetail: Bool = false
     @Published var pdfURL: URL?
 
+    // Animation state management with view ID for persistent tracking
+    private let animationViewId = "SchoolArrangementView"
+    @Published var shouldAnimate = false
+    
     private let baseURL = "https://www.wflms.cn"
     private var currentTask: URLSessionDataTask?
     private var detailTask: URLSessionDataTask?
@@ -25,6 +29,8 @@ class SchoolArrangementViewModel: ObservableObject {
 
     init() {
         fetchArrangements()
+        // Check if animations have already been performed
+        shouldAnimate = AnimationManager.shared.hasAnimated(viewId: animationViewId)
     }
 
     deinit {
@@ -721,4 +727,32 @@ class SchoolArrangementViewModel: ObservableObject {
             }
         }
     }
+    
+    // Enhanced animation control method with device-specific behavior
+    func triggerInitialAnimation(isSmallScreen: Bool = UIDevice.isSmallScreen) {
+        // Skip if already animated according to the global manager
+        if AnimationManager.shared.hasAnimated(viewId: animationViewId) {
+            // For small screens, instantly set the animation state without animation
+            if isSmallScreen {
+                self.shouldAnimate = true
+            } else {
+                // For larger screens, we can still animate if needed
+                withAnimation(.easeOut(duration: 0.3)) {
+                    self.shouldAnimate = true
+                }
+            }
+            return
+        }
+        
+        // First time animation with appropriate timing
+        let delay = isSmallScreen ? 0.1 : 0.3 // Less delay on small screens
+        
+        DispatchQueue.main.asyncAfter(deadline: .now() + delay) {
+            withAnimation(.easeOut(duration: isSmallScreen ? 0.4 : 0.6)) {
+                self.shouldAnimate = true
+                // Mark as animated in the global manager
+                AnimationManager.shared.markAnimated(viewId: self.animationViewId)
+            }
+        }
+    }
 }

Outspire.swiftpm/Features/SchoolArrangement/Views/SchoolArrangementSkeletonView.swift

@@ -13,7 +13,7 @@ struct SchoolArrangementSkeletonView: View {
                             .fill(Color.gray.opacity(0.2))
                             .frame(height: 22)
                             .frame(width: 200)
-                            .shimmering()
+                            //.shimmering()
 
                         Spacer()
 
@@ -22,7 +22,7 @@ struct SchoolArrangementSkeletonView: View {
                             .fill(Color.gray.opacity(0.2))
                             .frame(height: 16)
                             .frame(width: 100)
-                            .shimmering()
+                            //.shimmering()
                     }
 
                     // Week numbers skeleton
@@ -31,7 +31,7 @@ struct SchoolArrangementSkeletonView: View {
                             RoundedRectangle(cornerRadius: 12)
                                 .fill(Color.gray.opacity(0.2))
                                 .frame(width: 40, height: 24)
-                                .shimmering()
+                                //.shimmering()
                         }
 
                         Spacer()