Fix slash command registration

- Move verify command from class method to standalone function
- Register command using bot.tree.command() like Veil-Bot
- Commands now properly registered to guild at startup
- Use guild-specific command registration (not global)
- This matches the working implementation from Veil-Bot

Fixes: Slash command not appearing in Discord

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Copilot

bot.py

@@ -400,16 +400,106 @@ async def post_to_log_channel(self, embed: discord.Embed = None, file: discord.F
         except Exception as e:
             log.warning(f"[LOG] Could not send to log channel: {e}")
 
-    @app_commands.command(
+    @tasks.loop(hours=1)
+    async def update_stfc_ranks(self):
+        """Periodically check for rank changes and request admin confirmation."""
+        guild = self.get_guild(GUILD_ID)
+        if not guild:
+            log.warning("[UPDATE] Guild not found")
+            return
+
+        # Only run every UPDATE_CHECK_HOURS hours
+        await self._update_stfc_ranks_impl(guild)
+
+    async def _update_stfc_ranks_impl(self, guild: discord.Guild):
+        """Implementation of rank update checking."""
+        log.info("[UPDATE] Starting periodic rank check")
+
+        players = store.get_all_players()
+        log.info(f"[UPDATE] Found {len(players)} players to check")
+
+        for user_id, player_id in players:
+            member = guild.get_member(user_id)
+            if not member:
+                log.debug(f"[UPDATE] Member {user_id} no longer in guild")
+                continue
+
+            try:
+                player_data = STFCProScraper.fetch_player_data(player_id)
+                if not player_data:
+                    log.warning(f"[UPDATE] Could not fetch data for player {player_id}")
+                    continue
+
+                old_data = store.get_player_data(user_id)
+                if not old_data:
+                    continue
+
+                old_rank = old_data[4]  # rank is 5th column
+                new_rank = player_data.rank
+
+                # Check if rank changed
+                if old_rank != new_rank:
+                    log.info(f"[UPDATE] Rank change detected for {member.name}: {old_rank} → {new_rank}")
+
+                    # Update nickname in case it changed
+                    new_nick = self._build_nickname(player_data.alliance_tag, player_data.username)
+                    if member.nick != new_nick:
+                        try:
+                            await member.edit(nick=new_nick)
+                        except discord.Forbidden:
+                            log.warning(f"[UPDATE] Could not update nickname for {member.name}")
+
+                    # Request confirmation for ANY rank change
+                    confirmation_view = await self._assign_ranks(member, player_data, request_confirmation=True)
+
+                    # Update database
+                    store.store_stfc_player(user_id, player_data, old_data[5])  # screenshot_url is 6th column
+
+                    # Post confirmation request if needed
+                    if confirmation_view:
+                        admin_ping = f"<@&{ADMIN_ROLE_ID}>" if ADMIN_ROLE_ID else "Admins"
+                        alliance_display = f"[{player_data.alliance_tag}]" if player_data.alliance_tag else "N/A"
+                        confirm_embed = discord.Embed(
+                            title="🔔 Rank Change Detected - Confirmation Required",
+                            description=f"{admin_ping}, please confirm this rank change.",
+                            color=discord.Color.orange(),
+                        )
+                        confirm_embed.add_field(name="Player", value=f"{member.mention} ({player_data.username})", inline=False)
+                        confirm_embed.add_field(name="Previous Rank", value=old_rank or "N/A", inline=True)
+                        confirm_embed.add_field(name="New Rank", value=new_rank or "N/A", inline=True)
+                        confirm_embed.add_field(name="Alliance", value=alliance_display, inline=True)
+                        await self.post_to_log_channel(embed=confirm_embed, view=confirmation_view)
+
+            except Exception as e:
+                log.error(f"[UPDATE] Error checking player {player_id}: {e}")
+                continue
+
+    @update_stfc_ranks.before_loop
+    async def before_update_stfc_ranks(self):
+        """Wait for bot to be ready before starting update loop."""
+        await self.wait_until_ready()
+        # Adjust loop to run at specified intervals
+        current_hours = UPDATE_CHECK_HOURS
+        if current_hours > 0:
+            self.update_stfc_ranks.change_interval(hours=current_hours)
+
+
+# ---------------------------------------------------------------------------
+# Commands (Registered after bot instantiation)
+# ---------------------------------------------------------------------------
+def setup_commands(bot: STFCRankBot):
+    """Register slash commands with the bot."""
+
+    @bot.tree.command(
         name="verify",
-        description="Verify your STFC player account with alliance rank"
+        description="Verify your STFC player account with alliance rank",
+        guild=discord.Object(GUILD_ID),
     )
     @app_commands.describe(
-        player_url="Your stfc.pro/stfc.wtf player URL or player ID",
+        player_url="Your stfc.pro/stfc.wtf/stfc.live player URL or player ID",
         screenshot="Screenshot of your player profile (for verification logging)"
     )
     async def verify_command(
-        self,
         interaction: discord.Interaction,
         player_url: str,
         screenshot: discord.Attachment,
@@ -446,7 +536,7 @@ async def verify_command(
             return
 
         # Update nickname
-        new_nick = self._build_nickname(player_data.alliance_tag, player_data.username)
+        new_nick = bot._build_nickname(player_data.alliance_tag, player_data.username)
         try:
             await member.edit(nick=new_nick, reason="STFC Verification")
             log.info(f"[VERIFY] Updated nickname for {member.name}: {new_nick}")
@@ -465,7 +555,7 @@ async def verify_command(
         store.store_stfc_player(member.id, player_data, screenshot_url)
 
         # Assign ranks (base role immediate, higher ranks need confirmation)
-        confirmation_view = await self._assign_ranks(member, player_data, request_confirmation=False)
+        confirmation_view = await bot._assign_ranks(member, player_data, request_confirmation=False)
 
         # Success response
         embed = discord.Embed(
@@ -491,7 +581,7 @@ async def verify_command(
         log_embed.add_field(name="Rank", value=player_data.rank or "N/A", inline=True)
         log_embed.add_field(name="Server", value=str(player_data.server), inline=True)
         log_embed.set_image(url=screenshot_url)
-        await self.post_to_log_channel(embed=log_embed)
+        await bot.post_to_log_channel(embed=log_embed)
 
         # If rank requires confirmation, post confirmation request
         if confirmation_view:
@@ -504,90 +594,7 @@ async def verify_command(
             confirm_embed.add_field(name="Player", value=f"{member.mention} ({player_data.username})", inline=False)
             confirm_embed.add_field(name="Rank", value=player_data.rank, inline=True)
             confirm_embed.add_field(name="Alliance", value=alliance_display, inline=True)
-            await self.post_to_log_channel(embed=confirm_embed, view=confirmation_view)
-
-    @tasks.loop(hours=1)
-    async def update_stfc_ranks(self):
-        """Periodically check for rank changes and request admin confirmation."""
-        guild = self.get_guild(GUILD_ID)
-        if not guild:
-            log.warning("[UPDATE] Guild not found")
-            return
-
-        # Only run every UPDATE_CHECK_HOURS hours
-        await self._update_stfc_ranks_impl(guild)
-
-    async def _update_stfc_ranks_impl(self, guild: discord.Guild):
-        """Implementation of rank update checking."""
-        log.info("[UPDATE] Starting periodic rank check")
-
-        players = store.get_all_players()
-        log.info(f"[UPDATE] Found {len(players)} players to check")
-
-        for user_id, player_id in players:
-            member = guild.get_member(user_id)
-            if not member:
-                log.debug(f"[UPDATE] Member {user_id} no longer in guild")
-                continue
-
-            try:
-                player_data = STFCProScraper.fetch_player_data(player_id)
-                if not player_data:
-                    log.warning(f"[UPDATE] Could not fetch data for player {player_id}")
-                    continue
-
-                old_data = store.get_player_data(user_id)
-                if not old_data:
-                    continue
-
-                old_rank = old_data[4]  # rank is 5th column
-                new_rank = player_data.rank
-
-                # Check if rank changed
-                if old_rank != new_rank:
-                    log.info(f"[UPDATE] Rank change detected for {member.name}: {old_rank} → {new_rank}")
-
-                    # Update nickname in case it changed
-                    new_nick = self._build_nickname(player_data.alliance_tag, player_data.username)
-                    if member.nick != new_nick:
-                        try:
-                            await member.edit(nick=new_nick)
-                        except discord.Forbidden:
-                            log.warning(f"[UPDATE] Could not update nickname for {member.name}")
-
-                    # Request confirmation for ANY rank change
-                    confirmation_view = await self._assign_ranks(member, player_data, request_confirmation=True)
-
-                    # Update database
-                    store.store_stfc_player(user_id, player_data, old_data[5])  # screenshot_url is 6th column
-
-                    # Post confirmation request if needed
-                    if confirmation_view:
-                        admin_ping = f"<@&{ADMIN_ROLE_ID}>" if ADMIN_ROLE_ID else "Admins"
-                        alliance_display = f"[{player_data.alliance_tag}]" if player_data.alliance_tag else "N/A"
-                        confirm_embed = discord.Embed(
-                            title="🔔 Rank Change Detected - Confirmation Required",
-                            description=f"{admin_ping}, please confirm this rank change.",
-                            color=discord.Color.orange(),
-                        )
-                        confirm_embed.add_field(name="Player", value=f"{member.mention} ({player_data.username})", inline=False)
-                        confirm_embed.add_field(name="Previous Rank", value=old_rank or "N/A", inline=True)
-                        confirm_embed.add_field(name="New Rank", value=new_rank or "N/A", inline=True)
-                        confirm_embed.add_field(name="Alliance", value=alliance_display, inline=True)
-                        await self.post_to_log_channel(embed=confirm_embed, view=confirmation_view)
-
-            except Exception as e:
-                log.error(f"[UPDATE] Error checking player {player_id}: {e}")
-                continue
-
-    @update_stfc_ranks.before_loop
-    async def before_update_stfc_ranks(self):
-        """Wait for bot to be ready before starting update loop."""
-        await self.wait_until_ready()
-        # Adjust loop to run at specified intervals
-        current_hours = UPDATE_CHECK_HOURS
-        if current_hours > 0:
-            self.update_stfc_ranks.change_interval(hours=current_hours)
+            await bot.post_to_log_channel(embed=confirm_embed, view=confirmation_view)
 
 
 # ---------------------------------------------------------------------------
@@ -598,4 +605,5 @@ async def before_update_stfc_ranks(self):
     os.makedirs("screenshots", exist_ok=True)
 
     bot = STFCRankBot()
+    setup_commands(bot)
     bot.run(DISCORD_TOKEN)