Merge pull request #19 from ligangty/master

Enable PMD check for code convention in Commonjava

Author: jdcasey

pmd-ruleset.xml

@@ -0,0 +1,40 @@
+<?xml version="1.0"?>
+
+<ruleset name="Custom ruleset" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+  <description>
+    Commonjava PMD ruleset
+  </description>
+
+  <rule ref="rulesets/java/basic.xml"/>
+  <rule ref="rulesets/java/braces.xml"/>
+  <rule ref="rulesets/java/clone.xml"/>
+  <rule ref="rulesets/java/codesize.xml"/>
+  <rule ref="rulesets/java/coupling"/>
+  <rule ref="rulesets/java/comments"/>
+  <rule ref="rulesets/java/design"/>
+  <rule ref="rulesets/java/empty.xml"/>
+  <rule ref="rulesets/java/finalizers.xml"/>
+  <rule ref="rulesets/java/imports.xml">
+    <exclude name="TooManyStaticImports"/>
+  </rule>
+  <rule ref="rulesets/java/javabeans.xml"/>
+  <rule ref="rulesets/java/junit.xml"/>
+  <rule ref="rulesets/java/naming.xml"/>
+  <rule ref="rulesets/java/optimizations.xml"/>
+  <rule ref="rulesets/java/strictexception.xml">
+    <exclude name="AvoidCatchingThrowable"/>
+  </rule>
+  <rule ref="rulesets/java/strings.xml"/>
+  <rule ref="rulesets/java/sunsecure.xml"/>
+  <rule ref="rulesets/java/unnecessary.xml"/>
+  <rule ref="rulesets/java/unusedcode.xml"/>
+
+  <!--
+  <rule ref="rulesets/java/j2ee.xml"/>
+  <rule ref="rulesets/java/logging-jakarta-commons.xml"/>
+  <rule ref="rulesets/java/logging-java.xml"/>
+  -->
+
+</ruleset>

pom.xml

@@ -24,35 +24,35 @@
   <packaging>pom</packaging>
 
   <name>CommonJava Top-Level Parent POM</name>
-  
+
   <url>https://github.com/Commonjava/commonjava</url>
 
   <description>CommonJava top-level parent POM.</description>
   <inceptionYear>2012</inceptionYear>
-  
+
   <licenses>
     <license>
       <name>Apache License, Version 2.0</name>
       <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
       <distribution>repo</distribution>
     </license>
   </licenses>
-  
+
   <developers>
     <developer>
       <id>jdcasey</id>
       <email>jdcasey@commonjava.org</email>
       <name>John Casey</name>
     </developer>
   </developers>
-  
+
   <scm>
     <connection>scm:git:https://github.com/Commonjava/commonjava.git</connection>
     <developerConnection>scm:git:git@github.com:Commonjava/commonjava.git</developerConnection>
     <url>http://github.com/Commonjava/commonjava</url>
     <tag>HEAD</tag>
   </scm>
-  
+
   <properties>
     <javaVersion>1.7</javaVersion>
     <javaTestVersion>${javaVersion}</javaTestVersion>
@@ -76,6 +76,7 @@
     <version.plugin.install>2.4</version.plugin.install>
     <version.plugin.resources>2.6</version.plugin.resources>
     <version.plugin.site>3.3</version.plugin.site>
+    <version.plugin.pmd>3.6</version.plugin.pmd>
 
     <skipIllegalTransitiveEnforcement>false</skipIllegalTransitiveEnforcement>
     <enforceManagedDeps>true</enforceManagedDeps>
@@ -291,7 +292,7 @@
             </mapping>
           </configuration>
         </plugin>
-        
+
         <!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
         <plugin>
           <groupId>org.eclipse.m2e</groupId>
@@ -380,6 +381,24 @@
           <artifactId>maven-site-plugin</artifactId>
           <version>${version.plugin.site}</version>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-pmd-plugin</artifactId>
+          <version>${version.plugin.pmd}</version>
+          <configuration>
+            <targetJdk>${javaVersion}</targetJdk>
+            <ruleset>pmd-ruleset.xml</ruleset>
+          </configuration>
+          <executions>
+            <execution>
+              <phase>process-sources</phase>
+              <goals>
+                <goal>check</goal>
+                <goal>pmd</goal>
+              </goals>
+            </execution>
+          </executions>
+        </plugin>
       </plugins>
     </pluginManagement>
     <plugins>
@@ -388,10 +407,10 @@
       </plugin>
     </plugins>
   </build>
-  
+
   <profiles>
     <profile>
-      <id>formatting</id>
+      <id>cq</id>
       <build>
         <plugins>
           <plugin>
@@ -406,6 +425,10 @@
               </execution>
             </executions>
           </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-pmd-plugin</artifactId>
+          </plugin>
         </plugins>
       </build>
     </profile>