Skip to content

Enhanced file type validation #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vytisbulkevicius merged 3 commits into from
May 19, 2026
+31 −5
Merged

Enhanced file type validation #2798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62b3d5d
fix: enhance file type validation
girishpanchal30 May 13, 2026
a57d555
fix: improve file type validation
girishpanchal30 May 13, 2026
ff2d4fb
fix: improve file type validation
girishpanchal30 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions plugins/otter-pro/inc/plugins/class-form-pro-features.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,20 +129,46 @@ public function save_files_to_uploads( $form_data ) {
$file_data = $files[ $file_data_key ];

// Get the extension from file using WordPress functions.
$extension = wp_check_filetype( $file_data['name'] );
$file_validation = wp_check_filetype( $file_data['name'] );

if ( ! $extension['ext'] ) {
if ( ! $file_validation['ext'] || ! $file_validation['type'] ) {
$form_data->set_error( \ThemeIsle\GutenbergBlocks\Integration\Form_Data_Response::ERROR_FILE_UPLOAD_TYPE_WP );
break;
}

$form_files_ext = $field_option->get_option( 'allowedFileTypes' );

if ( ! empty( $form_files_ext ) ) {
$form_files_ext = str_replace( '.', '', $form_files_ext );
$form_files_ext = str_replace( '/*', '', $form_files_ext );
$mime_types = wp_get_mime_types();
$allowed_mimes = array();

$ext_to_mime = array();
foreach ( $mime_types as $exts => $mime ) {
$ext_list = explode( '|', $exts );
foreach ( $ext_list as $ext ) {
$ext_to_mime[ $ext ] = $mime;
}
}

foreach ( $form_files_ext as $type ) {
$type = strtolower( trim( str_replace( '.', '', $type ) ) );

// Handle wildcard mime types like image/*.
if ( false !== strpos( $type, '/' ) ) {
$allowed_mimes[] = $type;
continue;
}

// Use lookup map for direct access.
if ( isset( $ext_to_mime[ $type ] ) ) {
$allowed_mimes[] = $ext_to_mime[ $type ];
}
}

// Remove duplicate MIME types.
$allowed_mimes = array_unique( $allowed_mimes );

$mime_match = wp_match_mime_types( $form_files_ext, $extension['type'] );
$mime_match = wp_match_mime_types( $allowed_mimes, $file_validation['type'] );

if ( 0 == count( $mime_match ) ) {
$form_data->set_error( \ThemeIsle\GutenbergBlocks\Integration\Form_Data_Response::ERROR_FILE_UPLOAD_TYPE );
Comment thread
girishpanchal30 marked this conversation as resolved.
Expand Down
Loading