Skip to content

Fixed visibility conditions change on duplicated blocks #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vytisbulkevicius merged 2 commits into from
May 19, 2026
+10 −10
Merged

Fixed visibility conditions change on duplicated blocks #2797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b62ff
fix: visibility conditions change on duplicated blocks
girishpanchal30 May 13, 2026
6c322e7
fix: preserve visibility conditions for duplicated blocks
girishpanchal30 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/blocks/plugins/conditions/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
import { __ } from '@wordpress/i18n';

import { isEmpty } from 'lodash';
import { cloneDeep, isEmpty } from 'lodash';

import {
BaseControl,
Expand Down Expand Up @@ -389,15 +389,15 @@ const Edit = ({
}, [ attributes.otterConditions ]);

const addGroup = () => {
const otterConditions = [ ...( attributes.otterConditions || []) ];
const otterConditions = cloneDeep( attributes.otterConditions || [] );
const newGroupIndex = otterConditions.length; // Use the index of the new group
otterConditions.push([{}]);
setAttributes({ otterConditions });
Comment on lines 391 to 395
setOpenTabs(prev => new Set(prev).add(newGroupIndex));
};

const removeGroup = n => {
let otterConditions = [ ...attributes.otterConditions ];
let otterConditions = cloneDeep( attributes.otterConditions );
otterConditions.splice( n, 1 );

if ( ! Boolean( otterConditions.length ) ) {
Expand All @@ -408,13 +408,13 @@ const Edit = ({
};

const addNewCondition = index => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
otterConditions[ index ].push({});
setAttributes({ otterConditions });
};

const removeCondition = ( index, key ) => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
otterConditions[ index ].splice( key, 1 );

if ( 0 === otterConditions[ index ]) {
Expand All @@ -427,7 +427,7 @@ const Edit = ({
const changeCondition = ( value, index, key ) => {
window.oTrk?.set( `condition-type_${attributes?.id ?? name}_${index}_${key}`, { groupID: attributes?.id ?? name, feature: 'condition', featureComponent: 'condition-type', featureValue: value });

const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );

const attrs = applyFilters( 'otter.blockConditions.defaults', {}, value );

Expand Down Expand Up @@ -460,19 +460,19 @@ const Edit = ({
* @param {string} type The type of the condition.
*/
const changeArrayValue = ( value, index, key, type ) => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
otterConditions[ index ][ key ][ type ] = value;
setAttributes({ otterConditions });
};

const changeVisibility = ( value, index, key ) => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
otterConditions[ index ][ key ].visibility = 'true' === value ? true : false;
setAttributes({ otterConditions });
};

const changeValue = ( value, index, key, field ) => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
if ( null !== value ) {
otterConditions[ index ][ key ][ field ] = value;
} else {
Expand All @@ -490,7 +490,7 @@ const Edit = ({
* @param {string} type The type of the condition.
*/
const toggleValueInArray = ( value, index, key, type ) => {
const otterConditions = [ ...attributes.otterConditions ];
const otterConditions = cloneDeep( attributes.otterConditions );
if ( otterConditions[ index ][ key ][ type ]?.includes( value ) ) {
otterConditions[ index ][ key ][ type ] = otterConditions[ index ][ key ][ type ].filter( v => v !== value );
} else {
Expand Down
Loading