-
Notifications
You must be signed in to change notification settings - Fork 36
advanced-columns block drops wrapper HTML on block validation recovery #2813
Copy link
Copy link
Open
Labels
bugThis label could be used to identify issues that are caused by a defect in the product.This label could be used to identify issues that are caused by a defect in the product.customer reportIndicates the request came from a customer.Indicates the request came from a customer.regressionIssue represents a change in behavior from a previous version that is not intended or desired..Issue represents a change in behavior from a previous version that is not intended or desired..
Metadata
Metadata
Assignees
Labels
bugThis label could be used to identify issues that are caused by a defect in the product.This label could be used to identify issues that are caused by a defect in the product.customer reportIndicates the request came from a customer.Indicates the request came from a customer.regressionIssue represents a change in behavior from a previous version that is not intended or desired..Issue represents a change in behavior from a previous version that is not intended or desired..
Type
Fields
Give feedbackNo fields configured for Bug.
Description
Two issues reported this, but I wasn't able to reproduce it for the moment.
https://wordpress.org/support/topic/advanced-columns-block-drops-wrapper-html-on-block-validation-recovery/
From what I understand, they say it's a regression from this change #2777
Step-by-step reproduction instructions
Steps to reproduce
Build a page with an advanced-columns block, give it a background color and full-width alignment
Open the page in the block editor — if a block validation error appears, allow recovery (or simply save without addressing it)
Save the page
View the page on the front end — the wrapper
Why this is serious
The page appears completely unstyled with no visible error anywhere — not in the editor, not in the PHP error log. The user has no indication anything went wrong until they view the front end. On a Neve Pro site where advanced-columns is used on high-traffic pages this is a silent, recurring breakage triggered by any ordinary edit.
Suggested fix
Register a PHP render_callback for themeisle-blocks/advanced-columns so the block renders server-side. This would make the block resilient to any serialization mismatch and is the correct pattern for blocks whose front-end output depends on server-side state. Alternatively, ensure the JavaScript save() function reliably outputs the wrapper HTML in all recovery scenarios.
Screenshots, screen recording, code snippet or Help Scout ticket
No response
Environment info
No response
Is the issue you are reporting a regression
Yes, this is a regression.