refactor: deduplicate classifyGrant helper in expiration-buckets.test.ts

Author: brandonkachen

packages/billing/src/__tests__/expiration-buckets.test.ts

@@ -8,6 +8,15 @@ import {
 
 import type { GrantType } from '@codebuff/internal/db/schema'
 
+/**
+ * Classifies a grant into an expiration bucket based on its expires_at value.
+ * - Grants with expires_at set go to 'renewable' bucket
+ * - Grants with expires_at: null go to 'nonRenewable' bucket
+ */
+function classifyGrant(expiresAt: Date | null): CreditExpirationBucket {
+  return expiresAt ? 'renewable' : 'nonRenewable'
+}
+
 describe('Expiration Buckets', () => {
   describe('createInitialCreditBalance', () => {
     it('should return a CreditBalance with all values initialized to 0', () => {
@@ -59,10 +68,6 @@ describe('Expiration Buckets', () => {
     // - Grants with expires_at set go to 'renewable' bucket
     // - Grants with expires_at: null go to 'nonRenewable' bucket
 
-    function classifyGrant(expiresAt: Date | null): CreditExpirationBucket {
-      return expiresAt ? 'renewable' : 'nonRenewable'
-    }
-
     it('should classify grants with expires_at date as renewable', () => {
       const futureDate = new Date(Date.now() + 30 * 24 * 60 * 60 * 1000) // 30 days from now
       expect(classifyGrant(futureDate)).toBe('renewable')
@@ -217,10 +222,6 @@ describe('Expiration Buckets', () => {
     // - Zero-balance grants: add to principals/principalsByExpiration but NOT to breakdown/breakdownByExpiration
     // - Negative-balance (debt) grants: tracked separately via totalDebt, NOT added to any breakdown
 
-    function classifyGrant(expiresAt: Date | null): CreditExpirationBucket {
-      return expiresAt ? 'renewable' : 'nonRenewable'
-    }
-
     /**
      * Simulates the accumulation logic from calculateUsageAndBalance.
      * This mirrors lines 354-368 of balance-calculator.ts.